Skip to content

Commit bd06efb

Browse files
authored
Fix/load bai key (#113)
* fixed bug with calculation of upload key * same bug was present in load_bam and load_sqlite steps * fixed bug in main wf
1 parent b3f3760 commit bd06efb

File tree

3 files changed

+12
-7
lines changed

3 files changed

+12
-7
lines changed

gdc-dnaseq-aln-cwl/gdc_dnaseq.bamfastq_align.workflow.cwl

+6-3
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,8 @@ steps:
137137
input: transform/output_bam
138138
upload-bucket: bioclient_load_bucket
139139
upload-key:
140-
valueFrom: $(inputs.job_uuid)/$(inputs.input.basename)
140+
source: job_uuid
141+
valueFrom: $(self)/$(inputs.input.basename)
141142
out: [ output ]
142143

143144
load_bai:
@@ -149,7 +150,8 @@ steps:
149150
valueFrom: $(self.secondaryFiles[0])
150151
upload-bucket: bioclient_load_bucket
151152
upload-key:
152-
valueFrom: $(inputs.job_uuid)/$(inputs.input.nameroot).bai
153+
source: job_uuid
154+
valueFrom: $(self)/$(inputs.input.nameroot).bai
153155
out: [ output ]
154156

155157
load_sqlite:
@@ -159,7 +161,8 @@ steps:
159161
input: transform/sqlite
160162
upload-bucket: bioclient_load_bucket
161163
upload-key:
162-
valueFrom: $(inputs.job_uuid)/$(inputs.input.basename)
164+
source: job_uuid
165+
valueFrom: $(self)/$(inputs.input.basename)
163166
out: [ output ]
164167

165168
emit_bam_uuid:

gdc-dnaseq-prealn-cwl/gdc_dnaseq.aligned_reads.workflow.cwl

+6-3
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,8 @@ steps:
133133
input: transform/output_bam
134134
upload-bucket: bioclient_load_bucket
135135
upload-key:
136-
valueFrom: $(inputs.job_uuid)/$(inputs.input.basename)
136+
source: job_uuid
137+
valueFrom: $(self)/$(inputs.input.basename)
137138
out: [ output ]
138139

139140
load_bai:
@@ -145,7 +146,8 @@ steps:
145146
valueFrom: $(self.secondaryFiles[0])
146147
upload-bucket: bioclient_load_bucket
147148
upload-key:
148-
valueFrom: $(inputs.job_uuid)/$(inputs.input.nameroot).bai
149+
source: job_uuid
150+
valueFrom: $(self)/$(inputs.input.basename)
149151
out: [ output ]
150152

151153
load_sqlite:
@@ -155,7 +157,8 @@ steps:
155157
input: transform/sqlite
156158
upload-bucket: bioclient_load_bucket
157159
upload-key:
158-
valueFrom: $(inputs.job_uuid)/$(inputs.input.basename)
160+
source: job_uuid
161+
valueFrom: $(self)/$(inputs.input.basename)
159162
out: [ output ]
160163

161164
emit_bam_uuid:

tools/emit_json_value.cwl

-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ inputs:
99
type: File
1010
inputBinding:
1111
loadContents: true
12-
# valueFrom: $(null)
1312

1413
key:
1514
type: string

0 commit comments

Comments
 (0)