New fwi notebook overview by Olender · Pull Request #236 · NDF-Poli-USP/spyro

Olender · 2026-03-16T15:14:45Z

No description provided.

…th-setter-and-getters' into olender/focused_fwi_tutorial

…P/spyro into olender/focused_fwi_tutorial

Olender · 2026-03-16T15:17:41Z

+    "\n",
+    "**What is Full Waveform Inversion?**\n",
+    "\n",
+    "Classical FWI is an iterative PDE-constrained optimization process that minimizes a cost functional, such as, the difference between observed seismic data and synthetic data generated from a velocity model. The cost functional to be minimized varies depending on your desired FWI research. The process can involve:\n",


Decidir exclusão ou não

Olender · 2026-03-16T15:19:40Z

+    "\n",
+    "Let's set up our FWI problem parameters. We'll use a higher-order mass-lumped triangular finite element method (degree 4) for better accuracy, and define our mesh, acquisition geometry, and time domain settings.\n",
+    "\n",
+    "For a better understanding of why we chose degree higher-oder mass lumped triangles, please look at the [spyro paper](https://doi.org/10.5194/gmd-15-8639-2022)."


Remove this line e adicionar citação em cima

Olender · 2026-03-16T15:24:03Z

+   "id": "c4fa09e3",
+   "metadata": {},
+   "source": [
+    "Let us define our mesh dimensions. These are the mesh dimonsions for the domain of interest and do not include any absorbing layers."


Reduzir tamanho de malha e local dos receptores e fontes

Olender · 2026-03-16T15:26:14Z

+    "Here we define the acquisition geometry, including the properties of the sources and receivers.  \n",
+    "In this setup, we use **8 independent sources**.\n",
+    "\n",
+    "Since we are **not currently using source-encoding techniques** (only partially supported) nor a **supershot approach** (currently supported), each source requires a **fully independent forward propagation**. As a result, a total of **8 separate forward simulations** will be performed with this configuration.\n",


Remove the source-encoding and supershot comments and add a seperate notebook explaining them

Olender · 2026-03-16T15:27:56Z

+    "For this reason, it is recommended to **parallelize in multiples of 8** to achieve better performance.  \n",
+    "However, in the present case, the problem is solved **in serial**. The simulations are therefore executed sequentially, one after the other, with intermediate results stored in cache. These cached data are continuously overwritten or discarded between runs.\n",
+    "\n",
+    "I've also printed the source location value so you can see that create_transect creates a list of floats. The same is true for the receiver locations. Therefore, you can pass data to them directly, just remember that it has to be a list of floats."


Reduzir pra 4 fontes

Olender · 2026-03-16T15:33:15Z

+   "id": "44030540",
+   "metadata": {},
+   "source": [
+    "Let's add some Clayton-Engquist absorbing boundary conditions since they are local (without adding a pad), and therefore computationally cheap. For other more realistic cases we recommend using HABCs."


Olender · 2026-03-16T15:36:02Z

+   "id": "a409d9bb",
+   "metadata": {},
+   "source": [
+    "Here we define our time marching related parameters. Spyro is able to calculate the maximum stable timestep, but since this is outside of the scope of this tutorial we just set up a value we know will work. If youuse a time-step large enought that your problem becomes unstable you will receive an appropriate error."


Reduzir e colocar nota

Olender · 2026-03-16T15:42:22Z

+   "id": "dfee9c92",
+   "metadata": {},
+   "source": [
+    "Now we'll create the \"true\" velocity model that will generate our synthetic observed data. This model contains both circular and rectangular anomalies to create a little more complexity for the inversion challenge. I call this velocity model the Minas Cheese model. You will usually see in the literature a Camembert model consisting of only a circle, but since spyro's team is mostly Brazilian, we use the Brazilian Minas cheese model and take into account that in the 1700s gold used to be hidden inside Minas cheese wheels."


adicionar nota

Olender · 2026-03-16T15:43:32Z

+   "id": "dfee9c92",
+   "metadata": {},
+   "source": [
+    "Now we'll create the \"true\" velocity model that will generate our synthetic observed data. This model contains both circular and rectangular anomalies to create a little more complexity for the inversion challenge. I call this velocity model the Minas Cheese model. You will usually see in the literature a Camembert model consisting of only a circle, but since spyro's team is mostly Brazilian, we use the Brazilian Minas cheese model and take into account that in the 1700s gold used to be hidden inside Minas cheese wheels."


Explicar o "observado"

Olender · 2026-03-16T15:49:06Z

+    "    \"\"\"\n",
+    "    \n",
+    "    # Create FWI object for generating real data\n",
+    "    fwi = spyro.FullWaveformInversion(dictionary=dictionary)\n",


rever o objeto real

PAramos aqui

Olender · 2026-03-16T15:54:59Z

+            If True, output the velocity model to a pvd file for visualization.
+            Default is False.
+        dg_velocity_model : bool, optional
+            If True, use DG0 function space. Default is True.


CHange default to False

codecov · 2026-03-16T16:51:40Z

Codecov Report

❌ Patch coverage is 78.17259% with 86 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.10%. Comparing base (a7a5362) to head (7f3b6ff).
⚠️ Report is 540 commits behind head on main.

Files with missing lines	Patch %	Lines
spyro/utils/utils.py	37.77%	28 Missing ⚠️
spyro/meshing/meshing_functions.py	84.75%	25 Missing ⚠️
spyro/solvers/backward_time_integration.py	61.53%	10 Missing ⚠️
spyro/io/basicio.py	86.00%	7 Missing ⚠️
spyro/solvers/inversion.py	68.42%	6 Missing ⚠️
spyro/utils/velocity_to_grid.py	88.00%	3 Missing ⚠️
spyro/meshing/meshing_parameters.py	92.85%	2 Missing ⚠️
spyro/io/model_parameters.py	80.00%	1 Missing ⚠️
spyro/plots/plots.py	80.00%	1 Missing ⚠️
spyro/solvers/acoustic_wave.py	50.00%	1 Missing ⚠️
... and 2 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
+ Coverage   78.34%   82.10%   +3.76%     
==========================================
  Files          74       75       +1     
  Lines        5228     5489     +261     
==========================================
+ Hits         4096     4507     +411     
+ Misses       1132      982     -150

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Olender added 30 commits June 6, 2025 18:49

defining Firedrake version

1417f61

trying to fix ci

959fa47

trying to fix ci

1281aca

trying to fix ci

db3f5e3

trying to fix ci

168f271

trying to fix ci

8da7b56

trying to fix ci

869e210

trying to fix ci

4a51bb0

trying to fix real shot loading

afa0a47

improving

de142af

Merge remote-tracking branch 'origin/168-refactor-model-parameters-wi…

b90fc16

…th-setter-and-getters' into olender/focused_fwi_tutorial

fixing saving keyword error

a8d09ba

same as before

57ad002

finally fixed it

0e2f3cd

removing and fixing parallel prints

4f35a3f

renaming L to length for consistency

8c5e5a5

gitignore for pacmesh

189dd61

adding new meshing function and necessary parameters

f39be7e

seperate files to test new meshing function

852b239

got new mesh working internally

d459abe

updated example

8ca786b

started adding and testing velocity grid

0036a92

almost finished

5bfabad

moving test to correct folder

fb64594

fixing tests

aa27b68

fixing test

f14fc4e

renaming into test

e9109ad

fixing test

b227dd5

finished basic new mesh test

5a9916c

linting

a864726

Olender and others added 17 commits March 10, 2026 22:27

Documentation

f51c2e0

Merge branch 'main' into olender/focused_fwi_tutorial

f456b01

Merge branch 'main' into olender/focused_fwi_tutorial

dc56a0e

linting

9b5242b

Merge branch 'main' into olender/focused_fwi_tutorial

f43adc0

Merge branch 'olender/focused_fwi_tutorial' of github.com:NDF-Poli-US…

bc7a6c9

…P/spyro into olender/focused_fwi_tutorial

documentation

b1f7cbe

making gmsh a soft dependecy

0a23aed

linting

f3f8715

added automatic for input_models in cpw

d981826

improved docs and test coverage

5eaf0d3

linting

f190c43

Merge branch 'main' into olender/focused_fwi_tutorial

a6e90f9

increasing coverage

8cf43bb

doc changes

1b418f6

removing unnecessary delta_x

70b75ca

changing notebook

772813e

Olender commented Mar 16, 2026

View reviewed changes

changing text

7f3b6ff

Uh oh!

Conversation

Olender commented Mar 16, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov Bot commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov Bot commented Mar 16, 2026 •

edited

Loading