refactor wave parameters#329
Draft
Ig-dolci wants to merge 2 commits into
Draft
Conversation
Collaborator
Author
|
See issue #254. |
Member
|
I see you want to remove the _initialize_model_parameters and the set_initial_velocity_model from wave. THe set_material_property method was created to generalize it to different wave types and it should make those other methods obsolete |
Ig-dolci
commented
Jul 15, 2026
| dt_solver = Modal_Solver(self.dimension, method=method, | ||
| calc_max_dt=True) | ||
| max_dt = dt_solver.estimate_timestep(c, self.function_space, | ||
| max_dt = dt_solver.estimate_timestep(cfl_wave_speed, self.function_space, |
Collaborator
Author
There was a problem hiding this comment.
More thoughts about the CLF condition for general cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.