DO NOT SQUASH: Simple accurate vp output#330
Open
Olender wants to merge 8 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #330 +/- ##
==========================================
- Coverage 84.73% 84.63% -0.11%
==========================================
Files 97 98 +1
Lines 9379 9409 +30
==========================================
+ Hits 7947 7963 +16
- Misses 1432 1446 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR: New method to export scalar fields to segy or png and some io file reorganization
Since we use high-order FEM we cant visualize correctly in paraview. I've introduced a new utility function for exporting scalar fields to segy or png (for paper or report images). Now we can export our data to a more accurate (based on the grid space of the desired sampling) image. Unfortunately, since the parallelism related decorators were all over the place I had to reorganize them as well.
Therefore, this pull request refactors the
spyro/iomodule to improve code organization. I just moved the parallelism-related decorators and functions into a newparallelism_wrappersmodule, and updated the imports throughout the codebase. These changes help separate concerns between basic I/O operations and parallelism logic.Refactoring and Code Organization
ensemble_save,ensemble_load,ensemble_gradient,ensemble_functional,delete_tmp_files,switch_serial_shot,ensemble_shot_record,is_owner, andensemble_propagator) frombasicio.pyto a newparallelism_wrappers.pymodule, and updated imports accordingly throughout the codebase.New Features
export_scalar_fieldinsegy_io.pyto export scalar fields to SEG-Y or PNG formats, including logic for intermediate conversion and file validation. (spyro/io/segy_io.py,