Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributors page render error #212

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Conversation

James-Lu-none
Copy link
Collaborator

Description

the ListView.builder in the FutureBuilder has no specified height which causes RenderFlex overflowed, so it should be wrapped with a Expanded widget.

Implementation

Wrapped ListView.builder with a Expanded widget

Testing Instructions

Please provide details on the steps required to review and test this PR.

build the project and navigate to the contributors page and check if there are overflow error or not

@rileychh rileychh self-requested a review December 4, 2024 09:09
@rileychh rileychh added this to the 1.7 milestone Dec 4, 2024
@rileychh rileychh force-pushed the contributors_page_render_error branch from d048dd5 to 619197a Compare December 4, 2024 09:12
@rileychh rileychh merged commit 2cc13fd into master Dec 4, 2024
4 checks passed
@rileychh rileychh deleted the contributors_page_render_error branch December 4, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants