Completed "Course Student List in Course Info Page" #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntut-xuan
requested review from
Xanonymous-GitHub,
rileychh,
ricky9667,
James-Lu-none and
umeow0716
James-Lu-none
force-pushed
the
course-student-list
branch
2 times, most recently
from
785d84a to
7462308
Compare
rileychh
reviewed
Feb 19, 2024
lib/src/model/json_init.dart
Outdated
| static String stringInit(String value) { | ||
| return value ?? ""; | ||
| } | ||
|
|
||
| static List<T> listInit<T>(List<T> value) { | ||
| return value ?? [] as List<T>; | ||
| static List<T> listInit<T>(List<T> value){ |
There was a problem hiding this comment.
Was the white space before { accidentally deleted?
|
|
||
| @JsonSerializable() | ||
| class Course { | ||
| late int id; |
There was a problem hiding this comment.
Are we sure using ints to store the course IDs is sufficient to handle all cases? In other words, are we sure these IDs are always numbers and never exceed 2^31?
| @@ -181,6 +184,8 @@ class MessageLookup extends MessageLookupByLibrary { | |||
| "logoutWarning": | |||
| MessageLookupByLibrary.simpleMessage("Are you sure you want to log out? \nAll data will be cleared"), | |||
| "missingRequiredInformation": MessageLookupByLibrary.simpleMessage("Missing required information"), | |||
| "name": MessageLookupByLibrary.simpleMessage("name"), | |||
There was a problem hiding this comment.
Is this capitalized correctly?
| @@ -63,8 +65,7 @@ class _ISchoolPageState extends State<ISchoolPage> with SingleTickerProviderStat | |||
| } | |||
|
|
|||
| Widget tabPageView() { | |||
| CourseMainJson course = widget.courseInfo.main.course; | |||
|
|
|||
There was a problem hiding this comment.
Is this newline accidentally removed?
Comment on lines
55
to
62
| isHideSaturday = !courseTable.courses.any((course) => course.coursePeriods.any((coursePeriod) => coursePeriod.weekday == 6)); | ||
| isHideSunday = !courseTable.courses.any((course) => course.coursePeriods.any((coursePeriod) => coursePeriod.weekday == 7)); | ||
| isHideUnKnown = true; | ||
| isHideN = !courseTable.courses.any((course) => course.coursePeriods.any((coursePeriod) => coursePeriod.period == "N")); | ||
| isHideA = !courseTable.courses.any((course) => course.coursePeriods.any((coursePeriod) => coursePeriod.period == "A")); | ||
| isHideB = !courseTable.courses.any((course) => course.coursePeriods.any((coursePeriod) => coursePeriod.period == "B")); | ||
| isHideC = !courseTable.courses.any((course) => course.coursePeriods.any((coursePeriod) => coursePeriod.period == "C")); | ||
| isHideD = !courseTable.courses.any((course) => course.coursePeriods.any((coursePeriod) => coursePeriod.period == "D")); |
There was a problem hiding this comment.
Should we add a helper function here to reduce repetitive code?
Comment on lines
117
to
121
| List<String> list = []; | ||
| for(Course course in courseTable.courses){ | ||
| list.addAll(course.coursePeriods.map((coursePeriod) => coursePeriod.period).toList()); | ||
| } | ||
| return intList; | ||
| return list.toSet().toList(); |
There was a problem hiding this comment.
Is it possible to start list as a set so we don't have to convert it twice?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I completed the course student list shows in course info page.
It also contains to fetch department from credit query page or timeline page, please take a look about the
getDepartmentfunction incourse_info_page.dart.The department name only support in Chinese since it's too long in English version.
Implementation
iplus.Testing Instructions
Please check the course info page work correctly.
Additional Notes
Please note that it have some hard-coded rule in
getDepartmentfunction incourse_info_page.dart.It may need to migrate in the future or the rule is changed.