Fixup operator remote push #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will just print things out instead of running
when we were pushing these before, the registry was not getting their manifests properly. exporting these with `OCI-mediatypes` true produces a good manifest. this will eventually be the default, see moby/buildkit#6171 and moby/buildkit#6095
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when pushing the these before, the registry was not getting their manifests properly. exporting these with
OCI-mediatypestrue produces a good manifest. this will eventually be the default, see: moby/buildkit#6171 and moby/buildkit#6095also add a
--dry-runoptionGenerated
This pull request adds a new
--dry-runoption to theoperators/bake.shscript, allowing users to preview the Docker build commands without executing them. It also refactors how build arguments are assembled and ensures consistent use of provenance and registry output settings.New dry-run functionality:
DRY_RUNflag and a--dry-runcommand-line option to the script, enabling users to print the build commands instead of running them. [1] [2]DRY_RUNis enabled, the--printflag is included, causing Docker to output the build plan rather than execute it. [1] [2]Build command improvements:
--provenance=falseflag so it is always included, regardless of whether a specific target is set.--set "*.output=type=registry,oci-mediatypes=true"to the command.