WLM integration of GPU support #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Such information was no longer really useful. Removing it also makes things easier to activate the GPU support through setupRoot (workload manager integration).
Always attempt to automatically enable GPU support. We decided to avoid the alternative solution of having the user to explicitely request the GPU support activation through an extra workload manager's option. Such alternative solution wouldn't have been consistent with the interface of shifter when used without workload manager integration as well as the interface of nvidia-docker.
This reverts commit 016b860.
This reverts commit 6f1f6cf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds workload manager integration for GPU support + some minor changes.
We modified setupRoot to attempt to activate the Shifter's GPU support, and if the host doesn't provide GPU resources, the activation is silently skipped.
The minor changes are: