Skip to content

feat(mobile): wallet creation and import screens (#117)#125

Merged
Oluwaseyi89 merged 3 commits intoNFTopia-Foundation:mainfrom
KevinMB0220:feat/wallet-create-import-screens-117
Mar 30, 2026
Merged

feat(mobile): wallet creation and import screens (#117)#125
Oluwaseyi89 merged 3 commits intoNFTopia-Foundation:mainfrom
KevinMB0220:feat/wallet-create-import-screens-117

Conversation

@KevinMB0220
Copy link
Copy Markdown
Contributor

Summary

Test plan

Closes #117

…oundation#117)

Adds WalletCreateScreen and WalletImportScreen with mnemonic display,
backup confirmation checkbox, and secret key / recovery phrase import.
Includes typed stubs for StellarWalletService (NFTopia-Foundation#112) and AuthStore (NFTopia-Foundation#115)
so screens are ready to wire up once those issues land.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@drips-wave
Copy link
Copy Markdown

drips-wave bot commented Mar 25, 2026

@KevinMB0220 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Oluwaseyi89
Copy link
Copy Markdown
Contributor

@KevinMB0220 please wait for the zustand issue to be implemented fully to better incorporate it in your implementation.

@KevinMB0220
Copy link
Copy Markdown
Contributor Author

@KevinMB0220 please wait for the zustand issue to be implemented fully to better incorporate it in your implementation.

ok ok

@Oluwaseyi89
Copy link
Copy Markdown
Contributor

Oluwaseyi89 commented Mar 26, 2026

@KevinMB0220 apply to solve issues hindering your completion of this current issue. That is issue #112 and issue #115

@KevinMB0220
Copy link
Copy Markdown
Contributor Author

@KevinMB0220 apply to solve issues hindering your completion of this current issue. That is issue #112 and issue #115

I’ll apply for issue #112. I see that #115 is already assigned should I still take a look at it or coordinate with the assignee?

@Oluwaseyi89
Copy link
Copy Markdown
Contributor

@KevinMB0220 issue #115 is open, apply to work on it.

@KevinMB0220
Copy link
Copy Markdown
Contributor Author

@KevinMB0220 issue #115 is open, apply to work on it.

I already apllied

…flicts

Resolved add/add conflicts in:
- src/services/stellar/types.ts: merged EncryptedWallet/WalletError/WalletErrorCode
  from main with WalletCreateResult from HEAD (needed by create screen)
- src/services/stellar/wallet.service.ts: adopted real implementation from main,
  updated createWallet to return WalletCreateResult with mnemonic via StellarHDWallet
- src/stores/authStore.ts: adopted real Zustand implementation from main

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@KevinMB0220
Copy link
Copy Markdown
Contributor Author

@Oluwaseyi89 done

- Add expo-clipboard dependency to fix TS2307 in WalletCreateScreen and
  MnemonicDisplay (dynamic import now resolves types)
- Update wallet.service.test createWallet assertions to use result.wallet.*
  to match the WalletCreateResult return type
- Add generateMnemonic to stellar-hd-wallet mock so createWallet test works

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Oluwaseyi89 Oluwaseyi89 merged commit 326c3b3 into NFTopia-Foundation:main Mar 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement wallet creation screen with mnemonic phrase display and backup confirmation

2 participants