Closed
Conversation
…uced-impact logging
this commit doesn't include the base_file refenced in the patch as that will become available via NGEET#1358 when these are merged together
The workflow for merging these should run NGEET#1358 prior to this patch so this patch should use the default to make sure to include NGEET#1358 changes
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This pull request merges together #1358 and #1359, which are exclusively parameter file updates. This will also merge in #1355 which includes both parameter file updates and code changes associated with the parameter file update. #1355 has been tested seperately and found to be B4B.
Merging of this pull request is intended to be coordinated with ESCOMP/CTSM#3087.
Collaborators:
@ckoven @mpaiao
Expectation of Answer Changes:
Yes, the parameter val updates in #1358 and #1359 will result in answer changes to non-SP mode runs and logging runs specifically.
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
Documentation
Test Results:
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: