Skip to content

API 40 parameter file merge#1405

Closed
glemieux wants to merge 8 commits intoNGEET:mainfrom
glemieux:parameter-merge-api40
Closed

API 40 parameter file merge#1405
glemieux wants to merge 8 commits intoNGEET:mainfrom
glemieux:parameter-merge-api40

Conversation

@glemieux
Copy link
Contributor

@glemieux glemieux commented May 8, 2025

Description:

This pull request merges together #1358 and #1359, which are exclusively parameter file updates. This will also merge in #1355 which includes both parameter file updates and code changes associated with the parameter file update. #1355 has been tested seperately and found to be B4B.

Merging of this pull request is intended to be coordinated with ESCOMP/CTSM#3087.

Collaborators:

@ckoven @mpaiao

Expectation of Answer Changes:

Yes, the parameter val updates in #1358 and #1359 will result in answer changes to non-SP mode runs and logging runs specifically.

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@glemieux glemieux added parameters: value change Pertaining to changes to the parameter file only (i.e. not removing or adding new parameters) parameters: new Pertaining to adding new parameters to the parameter file labels May 8, 2025
@glemieux glemieux closed this May 8, 2025
@glemieux glemieux deleted the parameter-merge-api40 branch May 8, 2025 21:39
@glemieux
Copy link
Contributor Author

glemieux commented May 9, 2025

I closed this as during the merge in of the other pull requests, I merged my local copy of the PR branch and not the remote-tracking branch. As such, I think integrating this PR wouldn't have closed #1358 or #1359.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parameters: new Pertaining to adding new parameters to the parameter file parameters: value change Pertaining to changes to the parameter file only (i.e. not removing or adding new parameters)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants