Skip to content

Refactor boundary condition interface structure #1477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
glemieux wants to merge 327 commits into
base: main
Choose a base branch
from
Open

Refactor boundary condition interface structure #1477

glemieux wants to merge 327 commits into from
+2,576 −216

Conversation

@glemieux
Copy link
Contributor

@glemieux glemieux commented Sep 30, 2025

Description:

Collaborators:

Expectation of Answer Changes:

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

  • The in-code documentation has been updated with descriptive comments
  • The documentation has been assessed to determine if updates are necessary

Integrator

  • FATES PASS/FAIL regression tests were run
  • Evaluation of test results for answer changes was performed and results provided
  • FATES-CLM6 Code Freeze: satellite phenology regression tests are b4b

If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.

Documentation

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

@glemieux glemieux mentioned this pull request Sep 30, 2025
Closed
5 tasks
@glemieux glemieux marked this pull request as draft September 30, 2025 23:48
glemieux added 25 commits October 31, 2025 15:51
@glemieux
implement the updated api registry assignment of the column index
bad4850
@glemieux
whitespace
4b964da
@glemieux
adding comments and whitespace adjustments
d2a41b1
@glemieux
update the registry initialization to reflect the change to the subgr…
f35d8b7 
…id index information
@glemieux
add missing rank update
a28b2ab
@glemieux
add case select logic and pointers to index into the source data pointer
f3c34e7
@glemieux
add type-safe selection constructs to the update interface variable p…
bcfcb30 
…rocedure
@glemieux
move subgrid heirarchy values into fates interface types mod
32371cf
@glemieux
remove superseded transfer bc procedures
6e201bc
@glemieux
add intent in to all registry subroutines
1b475e3
@glemieux
remove defunct transferbcin/out procedures in patch type
16924aa
@glemieux
add data size to the var type
c001497
@glemieux
add dimension error diagnostics to the var type
7cf0087
@glemieux
convert variable size comparison error checking to a subroutine
05c8db9
@glemieux
add scalar interface register subroutine
1e6914f
@glemieux
add nlevsoil to patch-level bcin
2e00287
@glemieux
add interface key names as parameter variables
caece8c
@glemieux
move subgrid index types into fatesinterfacetypesmod
bd50484
@glemieux
move patch_api pointer update inside the do while
b4a3edc
@glemieux
todo comment updates
91e6307
@glemieux
removed unused indexers
88d0bd4
@glemieux
Correct which api has the subgrid indice update.
c6b3e97 
Technically we don't really need a subgrid_indices array for the patch-side currently.
@glemieux
adding comments for next steps
f5d7486
@glemieux
add update frequency to the registry variable type and and counters t…
e9ada14 
…o the api registry type

This will help next development steps in which the update of certain variables will be conducted prior to others
@glemieux
add filters to the registry api type to provide shorter loops during …
8b2f8c3 
…update calls
glemieux added 17 commits December 2, 2025 22:00
@glemieux
add conversion var type bound procedure
04cc591
@glemieux
add normalization procedure for accumulated litter fluxes
12eb316
@glemieux
implement conversation and nomralization procedures
082bea0
@glemieux
update all pool summation
691d337
@glemieux
add conversion flag check for parteh mode 2
5705634
@glemieux
Add zero_first attribute to interface variable types
470b736
@glemieux
update register subroutines to accept and pass in the is_first option…
4b59a72 
…al flag
@glemieux
Update conversion mechanism to be associated with Update subroutine
ba11f6d
@glemieux
type fix
8b45cf7
@glemieux
Add interface parameter for subgrid integer ids
06b6cb8
@glemieux
add subgrid_type optional argument for interface variable registration
21e8987
@glemieux
add issubgridtype function
a6c8824
@glemieux
add is_last to interface var type
61b72cb
@glemieux
add setlaststate to interface var type
21023c4
@glemieux
update the interface var update subroutine to new is_last variable
127f12e
@glemieux
add setlaststate to the interface type
e0ead67
@glemieux
add interface level subroutine to set last state
ba47570
@glemieux glemieux marked this pull request as ready for review January 28, 2026 17:36
@glemieux glemieux moved this to Finding Reviewers in FATES Pull Request Planning and Status Jan 28, 2026
glemieux added 11 commits January 28, 2026 09:46
@glemieux
remove temporary diagnostics from fatessoilbgcfluxmod
e64db77
@glemieux
reinstate area_frac in MIMICS portion of fluxintolitterpools
067e7ee
@glemieux
add comments to the new site type procedures
bb5b4f0
@glemieux
remove unused interface parameter
34b0a1e
@glemieux
add descriptive comments to the new fates interface registry procedures
2b51cf4
@glemieux
remove subgrid level parameters
32c2465 
Moved to the interfaceparameter module
@glemieux
add descriptive comments to the new interfacetypemod procedures
29e9a20
@glemieux
add more descriptive comments for the new interfacetype module proced…
106dfff 
…ures
@glemieux
add descriptive comments to the new interfacevartype procedures
3a03366
@glemieux
remove unused conversion calls
0a468c9 
These are now handled in Update automatically
@glemieux
change conversion (normalization_flag) to be an output of the update …
82137a9 
…procedure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

FATES Pull Request Planning and Status
Status: Finding Reviewers

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@glemieux