Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use webpack for the build step #165

Merged
merged 8 commits into from
Jul 19, 2024
Merged

Use webpack for the build step #165

merged 8 commits into from
Jul 19, 2024

Conversation

ttoino
Copy link
Member

@ttoino ttoino commented Mar 19, 2024

Closes #164.

This PR migrates the build step away from the current build-script.js and uses webpack instead. It's quite inspired by the config at Refined Github, but adapted to our specific needs.

This also migrates our project to corepack and yarn modern, so developers must run corepack enable before running yarn install.

@ttoino ttoino marked this pull request as ready for review April 8, 2024 16:32
@thePeras
Copy link
Member

thePeras commented Apr 8, 2024

Could you write the new script (corepack enable) before yarn install in the README file?

Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I make one change, it compiles, but keep repeating the compilation even If I don't touch the code source. Any idea of what may be?

@thePeras
Copy link
Member

thePeras commented Jul 5, 2024

The problem I commented before is now solved!

The only problem here is the WebpackShellPluginNext scripts, which don't run when new changes are saved. However the CopyPlugin works fine.

@thePeras thePeras self-requested a review July 16, 2024 13:45
Copy link
Collaborator

@toni-santos toni-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like Windows will still be a problem regarding watch scripts. :( However this is already a big improvement for the developer experience! Good job all 👍

Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ 🛫

@thePeras thePeras merged commit ba34c42 into develop Jul 19, 2024
@thePeras thePeras deleted the refactor/webpack branch July 19, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate the build step to a better system
3 participants