Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort tables #95

Merged
merged 6 commits into from
Aug 30, 2023
Merged

Sort tables #95

merged 6 commits into from
Aug 30, 2023

Conversation

thePeras
Copy link
Member

@thePeras thePeras commented Jul 3, 2023

Closes #62

Things to be done:

  • Add an icon
  • Descending sorting
  • Fix console errors at current account page, "Extrato Geral" tab

@thePeras thePeras marked this pull request as ready for review July 4, 2023 15:00
Copy link
Member

@ttoino ttoino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but it's breaking on some tables with two header rows, namely, the one on your "Percurso académico", while it works fine for others, like the ones on your "Posição no plano", and it does nothing on others, like on "Unidades curriculares" and "Estatutos e regimes de frequência"

@thePeras thePeras requested a review from ttoino August 2, 2023 20:52
Copy link
Member

@ttoino ttoino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It still seems to break for me, but only in this table.

image
image

@thePeras
Copy link
Member Author

thePeras commented Aug 30, 2023

It still seems to break for me, but only in this table.

I forget to mention that I didn't look to this table, as it will be remaked in #28

@ttoino ttoino merged commit 0019e88 into main Aug 30, 2023
@ttoino ttoino deleted the feature/sort-tables branch August 30, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tables Sort Columns
2 participants