-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce feature flags #1092
base: develop
Are you sure you want to change the base?
Introduce feature flags #1092
Conversation
7ef2024
to
7839ca9
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1092 +/- ##
========================================
- Coverage 11% 11% -0%
========================================
Files 269 278 +9
Lines 7345 7494 +149
========================================
+ Hits 802 805 +3
- Misses 6543 6689 +146 |
uni/lib/view/settings/widgets/feature_flags/feature_flags_dialog.dart
Outdated
Show resolved
Hide resolved
417c250
to
bd61b50
Compare
7839ca9
to
218b55e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add "group" feature flags? For instance, the feature flag new-redesign
will activate/deactivate many feature flags like: courses-page
, and schedule-page
. To make feature flags easier to interact with.
751733d
to
73be404
Compare
73be404
to
2c52f36
Compare
Closes #872
I included some example flags to clarify the normal use-case, they should be removed later when real feature flags are to be included
Workflow
featureFlagTable
featureFlagController.getFeatureFlag(<code>)
and save it in a static field (if you receive the errorNull check operator used on a null value
, it probably means the feature flag code is mismatched)ExperimentalFeatureWrapper
, and associate the latter to the feature flagReview checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change