Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package splitting for redesign #1282

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Package splitting for redesign #1282

merged 2 commits into from
Jul 23, 2024

Conversation

DGoiana
Copy link
Collaborator

@DGoiana DGoiana commented Jul 23, 2024

Closes #1255
Creates a separate package to write redesign components. This is the second pr as the first one (#1260) has too many conficts.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@DGoiana DGoiana mentioned this pull request Jul 23, 2024
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16%. Comparing base (99212cc) to head (1ef6309).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1282   +/-   ##
=======================================
  Coverage       16%     16%           
=======================================
  Files          233     233           
  Lines         7214    7214           
=======================================
  Hits          1139    1139           
  Misses        6075    6075           

Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good to me

@DGoiana DGoiana merged commit 47c42da into develop Jul 23, 2024
6 checks passed
@DGoiana DGoiana deleted the refactor/package-split branch July 23, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create redesign components separate package
3 participants