Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline #1302

Merged
merged 7 commits into from
Oct 16, 2024
Merged

Timeline #1302

merged 7 commits into from
Oct 16, 2024

Conversation

vitormpp
Copy link
Member

@vitormpp vitormpp commented Aug 21, 2024

Closes #1271

  • Widget with horizontally scrollable set of tabs and a corresponding vertical list of content

I have some concerns about the usage of global keys

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 12%. Comparing base (f6ac525) to head (77dca69).
Report is 15 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #1302    +/-   ##
========================================
+ Coverage       11%     12%    +1%     
========================================
  Files          267     266     -1     
  Lines         7321    7194   -127     
========================================
  Hits           802     802            
+ Misses        6519    6392   -127     

@vitormpp vitormpp marked this pull request as ready for review September 11, 2024 16:49
@DGoiana DGoiana requested review from a team September 11, 2024 21:25
Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is, really, really good! Nice job.

The only little possible improvement is removing the effect of selecting every option until getting to the desire one when clicking in one.

Copy link
Collaborator

@DGoiana DGoiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Nice job 🚀

@DGoiana DGoiana merged commit 7ca8cab into develop Oct 16, 2024
4 checks passed
@DGoiana DGoiana deleted the feature/timeline branch October 16, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New timeline
3 participants