-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeline #1302
Timeline #1302
Conversation
e5f72ea
to
4e87d81
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1302 +/- ##
========================================
+ Coverage 11% 12% +1%
========================================
Files 267 266 -1
Lines 7321 7194 -127
========================================
Hits 802 802
+ Misses 6519 6392 -127 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is, really, really good! Nice job.
The only little possible improvement is removing the effect of selecting every option until getting to the desire one when clicking in one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! Nice job 🚀
Closes #1271
I have some concerns about the usage of global keys