Feature/library rooms #658

jlcrodrigues · 2022-12-11T11:40:30Z

Closes #627
Fetched the reserved library rooms (gabinetes) from the website and displayed them in the library page.
This uses changes from #618.
If anyone wants to test this, rooms can be reserved here.

To view the currently reserved rooms, I added a card to the library page. The remove button is only a placeholder for now. Functionality will be added later (#656).

Moreover, when there's no rooms to display:

Review checklist

Terms and conditions reflect the current change
Contains enough appropriate tests
If aimed at production, writes new summary in whatsnew/whatsnew-pt-PT
Properly adds entry in changelog.md with the change
If PR includes UI updates/additions, its description has screenshots
Behavior is as expected
Clean, well structured code

…ect-schrodinger into feature/library-rooms

jlcrodrigues · 2023-02-12T21:50:52Z

This is now ready for review. Added tabs to the library page separating occupations and reservations. There's also a card for the home page.

Note that the remove button is not yet functional (#656 ). A way to create reservations will also be added later on (#657 ).

jlcrodrigues · 2023-03-15T23:24:52Z

This is now switched to providers.

Note: I used two routes for the reservation and rooms. Therefore, two items will appear in the drawer.

uni/lib/controller/local_storage/app_library_reservation.dart

uni/lib/model/providers/library_reservations_provider.dart

thePeras · 2023-03-16T10:39:45Z

uni/lib/view/library/library.dart

+        final TabController? tabController = DefaultTabController.of(context);
+        if (widget.startOnOccupation) {
+          tabController!.index = 1;
+        }


Should this be part of the state of the LibraryPageViewState and not getBody method context?

What I meant here is, should the final TabController? tabController be declared at LibraryPageViewState and not the getBody function?

uni/lib/view/library/library.dart

uni/lib/view/library/widgets/library_occupation_tab.dart

uni/lib/view/library/widgets/library_reservations_tab.dart

LuisDuarte1

Overall, it's a great progress to UNI and a great feature that it's not so easy to implement, so congratulations on that! I just have some minor feedback below, to make the code more maintainable and clean.

uni/lib/view/library/widgets/library_occupation_tab.dart

uni/lib/view/library/widgets/library_reservations_card.dart

uni/lib/view/library/widgets/library_reservations_tab.dart

LuisDuarte1 · 2023-03-16T13:10:38Z

uni/lib/view/library/widgets/reservation_row.dart

+import 'package:uni/model/entities/time_utilities.dart';
+
+class ReservationRow extends StatelessWidget {
+  final LibraryReservation? reservation;


I think you can remove the nullable type, since this can only be built if a reservation exists in library_reservations_tab.dart. And it makes the code more readable too and with less null checks, in this file.

uni/lib/view/library/widgets/library_reservations_tab.dart

uni/lib/model/providers/library_reservations_provider.dart

LuisDuarte1 · 2023-03-16T13:20:05Z

uni/lib/controller/local_storage/app_library_reservation.dart

+      '''CREATE TABLE RESERVATION(
+        id INTEGER PRIMARY KEY AUTOINCREMENT,
+        room TEXT,
+        startDate INT,


Make the startDate use the ISO 8601 standard instead of an unix epoch to improve database consistency between models, since Exams already use it and Schedules will use it.

jlcrodrigues · 2023-04-12T13:10:17Z

Thank you for the reviews. Made changes according to your suggestions.

I didn't use RequestDependentWidgetBuilder because this requires the use of helper functions, which I avoided using. This class should be refactored when #737 is done.

thePeras

✅ 🛫

uni/lib/view/library/widgets/library_reservations_card.dart

uni/lib/controller/local_storage/app_library_reservation.dart

LuisDuarte1

LGTM 🚀

jlcrodrigues added 17 commits November 13, 2022 22:22

Merge branch 'feature/library-occupation' into feature/library-rooms

6e3221e

feat: library reservations fetcher

3077511

Display reserved library rooms

c23cf3d

Merge branch 'feature/library-occupation' into feature/library-rooms

5ed8089

Merge branch 'feature/library-rooms'

cfec53e

Merge branch feature/library-occupation

83d9e1a

Merge branch 'feature/library-occupation' of github.com:NIAEFEUP/proj…

057e001

…ect-schrodinger into feature/library-rooms

Added library reservations card to main page

76cfe79

Added tabs to library page

36980a7

Reworked library data flow

fc95928

Merge branch 'develop'

6ce563e

Fix merge conflicts

af78294

Made changes to reserved rooms card

c2ecf16

Reworked library reservations' view

7e4b925

Added custom reservations route

53c2859

Small changes to library reservations

1aa923b

Merge branch 'develop'

9fa6414

jlcrodrigues marked this pull request as ready for review February 12, 2023 21:50

Merge branch 'develop' into feature/library-rooms

7cfd371

brunogomes30 changed the base branch from develop to feature/library-reservations March 15, 2023 15:20

brunogomes30 requested review from thePeras, LuisDuarte1, DGoiana and Process-ing March 15, 2023 15:20

Merge branch develop

fd285b4

jlcrodrigues marked this pull request as draft March 15, 2023 20:51

jlcrodrigues added 2 commits March 15, 2023 23:06

Fixed providers issues

a86709b

Refactored helper functions

c2d0834

jlcrodrigues marked this pull request as ready for review March 15, 2023 23:22

thePeras requested changes Mar 16, 2023

View reviewed changes

LuisDuarte1 requested changes Mar 16, 2023

View reviewed changes

jlcrodrigues added 2 commits April 12, 2023 13:49

Made changes according to suggestions

ea8af13

Finished requested changes

aad69ab

jlcrodrigues requested review from thePeras and LuisDuarte1 April 12, 2023 13:10

Fixed linter issues

9723a9b

jlcrodrigues mentioned this pull request Apr 26, 2023

Feature/cancel reservations #795

Open

7 tasks

thePeras approved these changes Apr 26, 2023

View reviewed changes

LuisDuarte1 requested changes Apr 26, 2023

View reviewed changes

uni/lib/view/library/widgets/library_reservations_card.dart Outdated Show resolved Hide resolved

Removed nullable type from RoomList

1a553fc

jlcrodrigues requested a review from LuisDuarte1 May 9, 2023 08:08

LuisDuarte1 requested changes May 13, 2023

View reviewed changes

uni/lib/controller/local_storage/app_library_reservation.dart Outdated Show resolved Hide resolved

Remove redundant reservation duration from db

34aac72

LuisDuarte1 approved these changes Jun 21, 2023

View reviewed changes

thePeras merged commit e582cf7 into feature/library-reservations Jun 21, 2023
3 checks passed

thePeras deleted the feature/library-rooms branch June 21, 2023 15:09

jlcrodrigues mentioned this pull request Dec 29, 2023

Feature/library reservations #1073

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/library rooms #658

Feature/library rooms #658

jlcrodrigues commented Dec 11, 2022

jlcrodrigues commented Feb 12, 2023

jlcrodrigues commented Mar 15, 2023

thePeras Mar 16, 2023

thePeras Apr 15, 2023

LuisDuarte1 left a comment

LuisDuarte1 Mar 16, 2023

LuisDuarte1 Mar 16, 2023

jlcrodrigues commented Apr 12, 2023

thePeras left a comment

LuisDuarte1 left a comment

Feature/library rooms #658

Feature/library rooms #658

Conversation

jlcrodrigues commented Dec 11, 2022

Review checklist

jlcrodrigues commented Feb 12, 2023

jlcrodrigues commented Mar 15, 2023

thePeras Mar 16, 2023

Choose a reason for hiding this comment

thePeras Apr 15, 2023

Choose a reason for hiding this comment

LuisDuarte1 left a comment

Choose a reason for hiding this comment

LuisDuarte1 Mar 16, 2023

Choose a reason for hiding this comment

LuisDuarte1 Mar 16, 2023

Choose a reason for hiding this comment

jlcrodrigues commented Apr 12, 2023

thePeras left a comment

Choose a reason for hiding this comment

LuisDuarte1 left a comment

Choose a reason for hiding this comment