Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/create reservations #998

Open
wants to merge 91 commits into
base: develop
Choose a base branch
from

Conversation

jlcrodrigues
Copy link
Contributor

Closes #657
Depends on #795

Added the ability to reserve library rooms from the reservations tab.

The website works especially slow for this service.

Also, there are a lot of errors that can occur for a reservation (e.g. library closed) so take this in mind to test.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior Is as expected
  • Clean, well-structured code

@jlcrodrigues jlcrodrigues changed the base branch from feature/library-reservations to develop January 11, 2024 22:45
@jlcrodrigues
Copy link
Contributor Author

In the meeting, it was discussed that instead of the Circular Indicator, the reservation should do an optimistic update. However, because the room number is only known after the request is complete, I tried adding a shimmer effect. Please let me know what you think.

@bdmendes
Copy link
Member

In the meeting, it was discussed that instead of the Circular Indicator, the reservation should do an optimistic update. However, because the room number is only known after the request is complete, I tried adding a shimmer effect. Please let me know what you think.

I like it, but I'll discuss it with the team nevertheless

@bdmendes bdmendes requested a review from a team January 12, 2024 14:09
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Merging #998 (3015163) into develop (9bbf5d4) will decrease coverage by 0%.
Report is 2 commits behind head on develop.
The diff coverage is 6%.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #998    +/-   ##
=======================================
- Coverage       17%    16%    -0%     
=======================================
  Files          207    217    +10     
  Lines         6418   6903   +485     
=======================================
+ Hits          1037   1067    +30     
- Misses        5381   5836   +455     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reserve rooms from the website
3 participants