Create annotation to validate role and serialize roles #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coutinho21
changed the title
coutinho21
force-pushed
the
feature/serialize-role
branch
from
f1d9d42
to
073d8e8
Compare
coutinho21
force-pushed
the
feature/serialize-role
branch
from
073d8e8
to
d83187b
Compare
bdmendes
force-pushed
the
feature/serialize-role
branch
2 times, most recently
from
26fe416
to
a949fd7
Compare
bdmendes
force-pushed
the
feature/serialize-role
branch
from
a949fd7
to
b0bf6c2
Compare
BrunoRosendo
reviewed
May 3, 2023
src/main/kotlin/pt/up/fe/ni/website/backend/controller/AuthController.kt
Outdated
Show resolved
Hide resolved
bdmendes
force-pushed
the
feature/serialize-role
branch
from
1977986
to
5123e2b
Compare
bdmendes
force-pushed
the
feature/serialize-role
branch
4 times, most recently
from
b03f3ec
to
ae82402
Compare
bdmendes
force-pushed
the
feature/serialize-role
branch
from
ae82402
to
e5213fe
Compare
|
Check the documentation preview: https://64b094777f7c04596edc78c5--niaefeup-backend-docs.netlify.app |
BrunoRosendo
requested changes
Aug 5, 2023
src/main/kotlin/pt/up/fe/ni/website/backend/controller/AuthController.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/pt/up/fe/ni/website/backend/controller/AuthController.kt
Show resolved
Hide resolved
src/main/kotlin/pt/up/fe/ni/website/backend/controller/AuthController.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/pt/up/fe/ni/website/backend/controller/AuthController.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/pt/up/fe/ni/website/backend/model/PerActivityRole.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/pt/up/fe/ni/website/backend/service/activity/AbstractActivityService.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/pt/up/fe/ni/website/backend/service/AuthService.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/pt/up/fe/ni/website/backend/config/security/AuthConfig.kt
Show resolved
Hide resolved
src/main/kotlin/pt/up/fe/ni/website/backend/service/AuthService.kt
Outdated
Show resolved
Hide resolved
|
I wrote about this feature in https://github.com/NIAEFEUP/website-niaefeup-backend/wiki/Roles-and-Generations#access-control, please update the information once this is finished |
coutinho21
force-pushed
the
feature/serialize-role
branch
from
21320d2
to
4434c16
Compare
|
Check the documentation preview: https://65060abbfbb37b4dc1cf0e8d--niaefeup-backend-docs.netlify.app |
|
Check the documentation preview: https://650b0e56a26a060465039aec--niaefeup-backend-docs.netlify.app |
BrunoRosendo
requested changes
Oct 6, 2023
src/main/kotlin/pt/up/fe/ni/website/backend/model/PerActivityRole.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/pt/up/fe/ni/website/backend/repository/ActivityRepository.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/pt/up/fe/ni/website/backend/service/AuthService.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/pt/up/fe/ni/website/backend/config/security/AuthConfig.kt
Show resolved
Hide resolved
coutinho21
force-pushed
the
feature/serialize-role
branch
from
5a4806f
to
edbfacf
Compare
|
Check the documentation preview: https://66ae04c443ec4d5daff6f5b5--niaefeup-backend-docs.netlify.app |
|
Check the documentation preview: https://66ae0969a22e2a6a3fea5206--niaefeup-backend-docs.netlify.app |
|
@BrunoRosendo pls review |
BrunoRosendo
approved these changes
Aug 13, 2024
Comment on lines
44
to
48
| return authentication.authorities.any { | ||
| val payload = it.toString().split(":") | ||
| payload.size == 2 && payload[0].toLong() == activityId && payload[1].split("-").any { p -> | ||
| p == permission.trim().uppercase(Locale.getDefault()) | ||
| } |
There was a problem hiding this comment.
I understand but I think it could be a bit more readable. Maybe extract some variables?
|
Check the documentation preview: https://66ca4d1fe850fcfa814462fb--niaefeup-backend-docs.netlify.app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #81
Review checklist