43 events gallery of photos #203

AvilaAndre · 2023-11-21T14:32:00Z

Closes #43

Creates the endpoints to manage events' photos.

Review checklist

Behavior is as expected
Clean, well structured code
Properly documents API changes in the corresponding controller test
Contains enough appropriate tests
Changes are reflected in the Wiki if necessary

MRita443 · 2023-11-28T15:06:33Z

Would it be possible to generalize the gallery to activity? We were discussing this today and think that projects benefit from a gallery too for all the images in their details page

AvilaAndre · 2023-11-28T16:45:12Z

Would it be possible to generalize the gallery to activity? We were discussing this today and think that projects benefit from a gallery too for all the images in their details page

Of course! I'll get onto it :)

github-actions · 2024-02-06T14:52:49Z

Check the documentation preview: https://65c247bae925ce12954d3af9--niaefeup-backend-docs.netlify.app

MRita443 · 2024-03-14T16:36:23Z

Hi @AvilaAndre are the alterations now ready?

MRita443

Few suggestions so far, will look at the tests after these changes :)

src/main/kotlin/pt/up/fe/ni/website/backend/model/Activity.kt

src/main/kotlin/pt/up/fe/ni/website/backend/service/activity/AbstractActivityService.kt

src/main/kotlin/pt/up/fe/ni/website/backend/service/ErrorMessages.kt

MRita443 · 2024-03-14T18:04:02Z

src/main/kotlin/pt/up/fe/ni/website/backend/controller/EventController.kt

@@ -74,4 +74,18 @@ class EventController(private val service: EventService) {
        @PathVariable idEvent: Long,
        @PathVariable idAccount: Long
    ) = service.removeTeamMemberById(idEvent, idAccount)
+
+    @PutMapping("/{idEvent}/gallery/addPhoto", consumes = ["multipart/form-data"])


@Sirze01 Could you verify the restfulness of these endpoints ;P?

...tlin/pt/up/fe/ni/website/backend/utils/documentation/payloadschemas/model/PayloadActivity.kt

src/main/kotlin/pt/up/fe/ni/website/backend/service/activity/AbstractActivityService.kt

Co-authored-by: Rita Lopes <[email protected]>

github-actions · 2024-03-29T01:09:30Z

Check the documentation preview: https://660614c8b18ed86d0f608ab8--niaefeup-backend-docs.netlify.app

BrunoRosendo

good job, this is looking good! I got a few suggestions

src/main/kotlin/pt/up/fe/ni/website/backend/controller/EventController.kt

src/main/kotlin/pt/up/fe/ni/website/backend/service/ErrorMessages.kt

BrunoRosendo · 2024-03-30T04:04:24Z

src/main/kotlin/pt/up/fe/ni/website/backend/service/activity/AbstractActivityService.kt

+        if (activity is Event) {
+            imageFolder = EventService.IMAGE_FOLDER
+        } else if (activity is Project) {
+            imageFolder = ProjectService.IMAGE_FOLDER
+        }


I think this is a big violation of OOP and we can improve this. My suggestion is to a method like this in the abstract activity service:

Suggested change

if (activity is Event) {

imageFolder = EventService.IMAGE_FOLDER

} else if (activity is Project) {

imageFolder = ProjectService.IMAGE_FOLDER

}

fun addGalleryImage(activityId: Long, image: MultipartFile, imageFolder: String): Activity {

val activity = getActivityById(activityId)

val fileName = fileUploader.buildFileName(image, activity.title)

val imageName = fileUploader.uploadImage(imageFolder + "/gallery", fileName, image.bytes)

activity.gallery.add(imageName)

return repository.save(activity)

}

And then add new methods to the project/events services where the name is chosen. This would maintain the logic and decouple the inheritance logic from the abstract service

Changed the highlighted code as proposed, while keeping the companion objects.

src/main/kotlin/pt/up/fe/ni/website/backend/service/activity/AbstractActivityService.kt

BrunoRosendo · 2024-03-30T04:05:34Z

src/test/kotlin/pt/up/fe/ni/website/backend/controller/EventControllerTest.kt

@@ -271,6 +274,89 @@ internal class EventControllerTest @Autowired constructor(
        }
    }

+    @NestedTest
+    @DisplayName("GET events/category/{category}")


Was this not tested before? I'm a bit confused since it seems out of scope for this PR

I honestly don't remember this part, my guess is that I updated the branch and needed to modify it to include the gallery.

BrunoRosendo · 2024-03-30T04:07:31Z

src/test/kotlin/pt/up/fe/ni/website/backend/controller/EventControllerTest.kt

+                    jsonPath("$.description").value(testEvent.description),
+                    jsonPath("$.teamMembers.length()").value(testEvent.teamMembers.size),
+                    jsonPath("$.gallery.length()").value(1),
+                    jsonPath("$.gallery[0]").value(expectedImagePath),


Have you (manually) tested if you can access this path on our machine (e.g. open in your browser)? I assume this was already tested for other images but I don't fully remember

It exists on the filesystem but the url does not work (I don't know if I am missing something because the port is 3000 and there is nothing there).

@BrunoRosendo

Please check #71 again, I'm pretty sure @DoStini already had the logic for this. There is a folder where Spring will save public files (see https://github.com/NIAEFEUP/website-niaefeup-backend/wiki/File-Upload#static-file-uploader)

I suspect the servePath is not being used correctly

github-actions · 2024-07-20T23:19:16Z

Check the documentation preview: https://669c45f2f8996dd696c64902--niaefeup-backend-docs.netlify.app

github-actions · 2024-07-20T23:26:59Z

Check the documentation preview: https://669c47c0b2a594ddcc9e90da--niaefeup-backend-docs.netlify.app

github-actions · 2024-07-21T01:05:33Z

Check the documentation preview: https://669c5eda12f07f61dbb35aea--niaefeup-backend-docs.netlify.app

AvilaAndre added 11 commits September 16, 2023 14:00

Adding gallery to event model and simple service methods

6885bee

Uploading image

6eca9e9

removed code added by accident

d6a1f3d

Changed galery image folder

0e67a81

Created addPhoto test

28c58f1

fixed photoUrl type and added errors when event/photo doesn't exist

3f061dc

test photo add if event does not exist

a8b0c9e

test photo add wrong image format test

e2262dd

Remove photo from gallery test

8a2f4b9

gallery photo remove from unexistent event test

79ee8f1

gallery remove unexistent photo test

c8d19ef

AvilaAndre linked an issue Nov 21, 2023 that may be closed by this pull request

events: gallery of photos #43

Open

AvilaAndre and others added 3 commits January 30, 2024 17:26

generalized gallery to activity

4b0634f

Move gallery service methods from Event to Activity

50acea5

Merge branch 'develop' into 43-events-gallery-of-photos

91f0ea6

AvilaAndre marked this pull request as ready for review February 6, 2024 14:23

AvilaAndre added 2 commits February 6, 2024 14:29

added gallery to develop tests

91ace92

added gallery documentation to activity payload

a3516e7

AvilaAndre requested a review from MRita443 February 6, 2024 16:14

MRita443 requested changes Mar 14, 2024

View reviewed changes

AvilaAndre and others added 6 commits March 28, 2024 01:21

Update src/main/kotlin/pt/up/fe/ni/website/backend/model/Activity.kt

cd6f37f

Co-authored-by: Rita Lopes <[email protected]>

Added missing import

971b2c0

Formatted imports

6b3e978

Removed unnnecessary code

c6f4c3c

Replaced photo with image

31d5a4b

added image folder to gallery

8639688

AvilaAndre added 2 commits March 28, 2024 20:38

Updated gallery documentation

1863c6f

Fixing tests failing after changes

250bb18

BrunoRosendo requested changes Mar 30, 2024

View reviewed changes

replace endpoints to be restful and add delete method to testing

dd4818b

generalized image to file

1b664c1

added file deletion to FileUploader class and delete files on removal

02ced4e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

43 events gallery of photos #203

43 events gallery of photos #203

AvilaAndre commented Nov 21, 2023

MRita443 commented Nov 28, 2023

AvilaAndre commented Nov 28, 2023

github-actions bot commented Feb 6, 2024

MRita443 commented Mar 14, 2024

MRita443 left a comment

MRita443 Mar 14, 2024

github-actions bot commented Mar 29, 2024

BrunoRosendo left a comment

BrunoRosendo Mar 30, 2024

AvilaAndre Jul 20, 2024

BrunoRosendo Mar 30, 2024

AvilaAndre Mar 30, 2024

BrunoRosendo Mar 30, 2024

AvilaAndre Jul 21, 2024 •

edited

Loading

MRita443 Aug 12, 2024

BrunoRosendo Aug 13, 2024

github-actions bot commented Jul 20, 2024

github-actions bot commented Jul 20, 2024

github-actions bot commented Jul 21, 2024

-        if (activity is Event) {
-            imageFolder = EventService.IMAGE_FOLDER
-        } else if (activity is Project) {
-            imageFolder = ProjectService.IMAGE_FOLDER
-        }
+fun addGalleryImage(activityId: Long, image: MultipartFile, imageFolder: String): Activity {
+        val activity = getActivityById(activityId)
+        val fileName = fileUploader.buildFileName(image, activity.title)
+        val imageName = fileUploader.uploadImage(imageFolder + "/gallery", fileName, image.bytes)
+        activity.gallery.add(imageName)
+        return repository.save(activity)
+    }

43 events gallery of photos #203

Are you sure you want to change the base?

43 events gallery of photos #203

Conversation

AvilaAndre commented Nov 21, 2023

Review checklist

MRita443 commented Nov 28, 2023

AvilaAndre commented Nov 28, 2023

github-actions bot commented Feb 6, 2024

MRita443 commented Mar 14, 2024

MRita443 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Mar 29, 2024

BrunoRosendo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AvilaAndre Jul 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jul 20, 2024

github-actions bot commented Jul 20, 2024

github-actions bot commented Jul 21, 2024

AvilaAndre Jul 21, 2024 •

edited

Loading