Save functionality added in GUI file menu #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djmgit
requested changes
Feb 3, 2018
|
Please have a look at this. |
|
ok.. i will look into it |
|
@realsdx great :) |
|
its for python3 only |
|
@realsdx yes please, actually as of now the app is for both py2 and py3. So py2 support is required :) |
|
Done. |
|
@realsdx will review it ASAP |
|
I forgot to squash the commits, sorry for that |
|
@realsdx since this is your second PR, it is a good time to learn how to squash commits. I would suggest you to squash your commits for this PR as it is very essential :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#81 Added the save functionality in GUI filemenu