Conversation
gbarter
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue in WEIS CI: https://github.com/WISDEM/WEIS/actions/runs/17865395593/job/50806345035?pr=426#step:10:15827
For reference: https://github.com/Gunnstein/fatpack/blob/82d4aeef031f803d09edb1893a6c4587fa3adfd2/fatpack/rainflow.py#L446
We could also use
find_rainflow_ranges_strictin fatpack, which also worked.In the short WEIS tests, there is not always a full cycle to measure, and for some reason, it returns duplicate cycle ranges.
The parallel read function is just a trivial application of the
readfunction using multiprocessing, but it helps when parsing several files.