Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add technical details to Contributing page #289

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

egpbos
Copy link
Member

@egpbos egpbos commented Oct 17, 2023

Implementation and configuration details are necessary context for some high-level contributions. For instance, #266 about a "successful build" GH Action is not applicable in light of these details.

Fixes #266.

Implementation and configuration details are necessary context for some high-level contributions. For instance, #266 about a "successful build" GH Action is not applicable in light of these details.

Fixes #266.
@bouweandela
Copy link
Member

@sverhoeven could you please have a look if this describes how you implemented it?

Copy link
Member

@sverhoeven sverhoeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing these details.

It mostly looks correct.
I do have some clarifications.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
Co-authored-by: Stefan Verhoeven <[email protected]>
@egpbos egpbos merged commit 08be19a into main Oct 24, 2023
1 check passed
@egpbos egpbos deleted the contributing_technical_details branch October 24, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a build GH Actions workflow
3 participants