Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder tests of architectures in seperate test suites #222

Closed
cwmeijer opened this issue Mar 17, 2020 · 4 comments · Fixed by #259
Closed

Reorder tests of architectures in seperate test suites #222

cwmeijer opened this issue Mar 17, 2020 · 4 comments · Fixed by #259
Assignees
@bsolino @florian-huber
Labels
code quality
Milestone
Sprint 07/2020

Comments

@cwmeijer
Copy link
Member

Tests of several architectures are now together in 1 big suite with comments seperating tests for one architecture from tests for the next. Instead of comments we should use test suites to seperate them.
@cwmeijer cwmeijer added this to the Sprint 07/2020 milestone Jul 15, 2020
@cwmeijer cwmeijer mentioned this issue Jul 27, 2020
Closed
@florian-huber
Copy link
Contributor

Since we now anyway work on moving models to individual classes, we can split the tests accordingly --> PR #239

@bsolino
Copy link
Contributor

bsolino commented Jul 28, 2020

Maybe we can do it in two separate steps, so it's easier to review the code.

@florian-huber
Copy link
Contributor

Yes, agreed. I moved the new tests into the "old" modelgen test suite to make the PR #239 a bit simpler.
We can move it to individual test files later (test_model_cnn.py etc.).

@florian-huber florian-huber mentioned this issue Jul 30, 2020
Merged
@bsolino
Copy link
Contributor

bsolino commented Jul 30, 2020

Currently working on this on branch reorder_tests_222

@bsolino bsolino mentioned this issue Jul 30, 2020
Merged
@bsolino bsolino linked a pull request Jul 30, 2020 that will close this issue
Reorder model tests to own files. Issue #222 #259
Merged
@bsolino bsolino mentioned this issue Jul 30, 2020
Closed
bsolino added a commit that referenced this issue Jul 31, 2020
@bsolino
Merge pull request #259 from NLeSC/reorder_tests_222
e636468 
Reorder model tests to own files. Issue #222
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsolino bsolino

@florian-huber florian-huber

Labels
code quality
Projects
None yet
Milestone
Sprint 07/2020
Development

Successfully merging a pull request may close this issue.

Reorder model tests to own files. Issue #222 NLeSC/mcfly
3 participants
@cwmeijer @bsolino @florian-huber