Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder model tests to own files. Issue #222 #259

Merged
merged 19 commits into from
Jul 31, 2020
Merged

Reorder model tests to own files. Issue #222 #259

merged 19 commits into from
Jul 31, 2020

Conversation

bsolino
Copy link
Contributor

@bsolino bsolino commented Jul 30, 2020 •
edited
Loading

Pull request for issue #222

bsolino added 14 commits July 30, 2020 17:29
@bsolino
Moved tests out for CNN and ConvLSTM models
bc2381a
@bsolino
Moved function to a public spot
f9bae2d
@bsolino
Moved out tests for ResNet
5d12609
@bsolino
InceptionTime was named as ResNet in some comments
284fafd
@bsolino
Moved out InceptionTime tests
a3084a7
@bsolino
Removed unused imports
827713b
@bsolino
Test to guarantee that Travis is picking up these files
e2ef961
@bsolino
Revert "Test to guarantee that Travis is picking up these files"
ae99b38 
This reverts commit e2ef961.

Previous commit proved unnecessary.
@bsolino
Moved files out of subfolder because they failed imports
35818a9
@bsolino
Revert "Moved files out of subfolder because they failed imports"
2983d2a 
This reverts commit 35818a9.

Moved wrong files
@bsolino
Moved model tests out from subfolder because of failed imports in Travis
3828386
@bsolino
Corrected import
24284ec
@bsolino
Added main to execute test locally
e1bf3f1
@bsolino
Import generate train data
07cf115
@bsolino bsolino linked an issue Jul 30, 2020 that may be closed by this pull request
Reorder tests of architectures in seperate test suites #222
Closed
@bsolino bsolino self-assigned this Jul 30, 2020
@bsolino bsolino linked an issue Jul 30, 2020 that may be closed by this pull request
test_ResNet_hyperparameters Fails randomly with wrong network depth. #258
Closed
@bsolino bsolino mentioned this pull request Jul 30, 2020
Closed
@bsolino bsolino changed the title Reorder tests 222 Reorder model tests to own files. Issue #222 Jul 30, 2020
@cwmeijer cwmeijer self-assigned this Jul 31, 2020
@cwmeijer cwmeijer self-requested a review July 31, 2020 09:10
cwmeijer
cwmeijer requested changes Jul 31, 2020
View reviewed changes
Copy link
Member

@cwmeijer cwmeijer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR. No surprises. 👍
Made 2 suggestions.

tests/test_modelgen.py Outdated Show resolved Hide resolved
tests/test_modelgen.py Show resolved Hide resolved
This was referenced Jul 31, 2020
Closed
Merged
@bsolino bsolino merged commit e636468 into master Jul 31, 2020
@cwmeijer cwmeijer deleted the reorder_tests_222 branch July 31, 2020 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwmeijer cwmeijer cwmeijer requested changes

Assignees

@cwmeijer cwmeijer

@bsolino bsolino

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@bsolino @cwmeijer