- Fix for char signedness warnings on NetBSD.

NLnetLabs · Aug 21, 2024 · 6b3266a · 6b3266a
1 parent 4f52461
commit 6b3266a
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 3 deletions.
diff --git a/doc/Changelog b/doc/Changelog
@@ -1,5 +1,6 @@
 21 August 2024: Wouter
 	- Add cross platform freebsd, openbsd and netbsd to github ci.
+	- Fix for char signedness warnings on NetBSD.
 
 20 August 2024: Wouter
 	- Add iter-scrub-ns, iter-scrub-cname and max-global-quota

diff --git a/services/modstack.c b/services/modstack.c
@@ -265,7 +265,7 @@ modstack_call_init(struct module_stack* stack, const char* module_conf,
         int i, changed = 0;
         env->need_to_validate = 0; /* set by module init below */
         for(i=0; i<stack->num; i++) {
-		while(*module_conf && isspace(*module_conf))
+		while(*module_conf && isspace((unsigned char)*module_conf))
 			module_conf++;
                 if(strncmp(stack->mod[i]->name, module_conf,
 			strlen(stack->mod[i]->name))) {

diff --git a/testcode/unitzonemd.c b/testcode/unitzonemd.c
@@ -108,7 +108,7 @@ static void zonemd_generate_test(const char* zname, char* zfile,
 	digestdup = strdup(digest);
 	unit_assert(digestdup);
 	for(i=0; i<strlen(digestdup); i++) {
-		digestdup[i] = toupper(digestdup[i]);
+		digestdup[i] = toupper((unsigned char)digestdup[i]);
 	}
 	if(verbosity >= VERB_ALGO) {
 		char zname[255+1];

diff --git a/util/config_file.c b/util/config_file.c
@@ -2332,7 +2332,7 @@ uint8_t* cfg_parse_nsid(const char* str, uint16_t* nsid_len)
 		uint8_t *dp;
 
 		for ( ch = str, dp = nsid
-		    ; isxdigit(ch[0]) && isxdigit(ch[1])
+		    ; isxdigit((unsigned char)ch[0]) && isxdigit((unsigned char)ch[1])
 		    ; ch += 2, dp++) {
 			*dp  = (uint8_t)sldns_hexdigit_to_int(ch[0]) * 16;
 			*dp += (uint8_t)sldns_hexdigit_to_int(ch[1]);