-
Notifications
You must be signed in to change notification settings - Fork 30
add grid2obs plot_by_level and mean timeseries plots #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add grid2obs plot_by_level and mean timeseries plots #197
Conversation
|
Hi @QiShi-NOAA! We just merged @Ho-ChunHuang-NOAA's satellite step2 PR into the feature/ss193 branch, so please make sure that 1) your fork is synced and 2) your branch is up-to-date with feature/ss193. Once your branch is updated, please let me know and I will start testing your PR. Thanks! |
|
@AliciaBentley-NOAA I've updated my branch. |
|
@QiShi-NOAA I have begun testing your PR! The job is still running (~27 minutes into the run). You can find the output below. Please check the log file and the output to make sure things look how you expect when the job completes. Log: /gpfs/f6/ira-sti/world-shared/Alicia.Bentley/verif_global_standalone_step2/tmp/verif_global.1941241/batch_jobs/verif_global_grid2obs_step2.out Would you be able to screenshot or push these images to emcrzdm for us to view? |
|
@QiShi-NOAA The GRID2OBS step2 job has completed and created some relatively small grid2obs plot .tar files. Plots: /gpfs/f6/ira-sti/world-shared/Alicia.Bentley/plots/tar_plot_files/ -rw-r--r-- 1 Alicia.Bentley ira-sti 1.2G Jan 8 12:29 verif_global_grid2obs_step2_conus_sfc.tar |
|
@AliciaBentley-NOAA There is no ERROR and Error in the log file. The mean and stat_by_level plots are generated:
|
|
@QiShi-NOAA Thanks! I will do my final code review now! |
AliciaBentley-NOAA
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have looked over the coding changes made in this PR and I think that they look good. Only parm/config/driver_standalone_step2_plots.sh and the ush/plots/grid2obs scripts were updated. The job ran without errors or warnings. The new grid2obs plots were produced. I approve this PR to be merged!
@QiShi-NOAA Can you please confirm that your fork is synced?
|
@AliciaBentley-NOAA I confirm the fork is synced |
|
@QiShi-NOAA Please update the EMC_verif-global Github issue and say that your grid2obs step2 PR has been merged when you get the chance! @Ho-ChunHuang-NOAA You can also update the EMC_verif-global Github issue and say that your satellite step2 PR has been merged when you get the chance! Thanks, all! |
|
@AliciaBentley-NOAA Will do. |


Description of Changes
Add plot_by_level and mean (fbar_obar) timeseries plots to grid2obs step2.
Developer Questions and Checklist
Is this a high priority PR? If so, why and is there a date it needs to be merged by? No
Do you have any planned upcoming annual leave/PTO? No
Testing Instructions for Running driver_standalone_step2_plots.sh
In /parm/config/driver_standalone_step2_plots.sh, make sure the following are set:
export RUN_GRID2OBS_STEP2="YES"
export model_stat_dir_list="gpfs/f6/ira-sti/world-shared/Qi.Shi/KEEP_archive/prod /gpfs/f6/ira-sti/world-shared/Qi.Shi/KEEP_archive/dev"
export OUTPUTROOT="/gpfs/f6/drsa-precip3/world-shared/$USER/verif_global_standalone_step2" (If you want to change this to "ira-sti", be sure to do so)
export tar_archive_dir="/gpfs/f6/ira-sti/world-shared/$USER/KEEP_archive/tar_plot_files" (Make sure this is where you want the final tar files to go; you don't need to have already created this directory because the tar script will do so for you)
export start_date=20241106
export end_date=20241121
Go to the ush/ directory and submit the job:
./run_verif_global.sh ../parm/config/driver_standalone_step2_plots.sh