Skip to content

feature/EVS-GLWU_move_STEP#920

Open
SamiraArdani-NOAA wants to merge 3 commits intoNOAA-EMC:developfrom
SamiraArdani-NOAA:feature/EVS-GLWU_move_STEP
Open

feature/EVS-GLWU_move_STEP#920
SamiraArdani-NOAA wants to merge 3 commits intoNOAA-EMC:developfrom
SamiraArdani-NOAA:feature/EVS-GLWU_move_STEP

Conversation

@SamiraArdani-NOAA
Copy link
Contributor

@SamiraArdani-NOAA SamiraArdani-NOAA commented Mar 6, 2026

Note to developers: You must use this PR template!

Description of Changes

Please include a summary of the changes and the related GitHub issue(s). Please also include relevant motivation and context.

This PR updates the EVS-GLWU naming conventions by moving the ${STEP} variable earlier in the filename (closes #917). In addition, the "last31days" plots were separated from "last90days" to align with the other operational components in EVS. Validation testing confirms the updates are functional for these changes.

Developer Questions and Checklist

  • Is this a high priority PR? If so, why and is there a date it needs to be merged by?
    No.
  • Do you have any planned upcoming annual leave/PTO?
    No.
  • Are there any changes needed in the times when the jobs are supposed to run/kick-off?
    No.
  • The code changes follow NCO's EE2 Standards.
  • Developer's name is removed throughout the code and have used ${USER} where necessary throughout the code.
  • References the feature branch for HOMEevs are removed from the code.
  • J-Job environment variables, COMIN and COMOUT directories, and output follow what has been defined for EVS.
  • Jobs over 15 minutes in runtime have restart capability.
  • If applicable, changes in the dev/drivers/scripts or dev/modulefiles have been made in the corresponding ecf/scripts and ecf/defs/evs-nco.def?
  • Jobs contain the appropriate file checking and don't run METplus for any missing data.
  • Code is using METplus wrappers structure and not calling MET executables directly.
  • Log is free of any ERRORs or WARNINGs.

Testing Instructions

Please include testing instructions for the PR assignee. Include all relevant input datasets needed to run the tests.

Environment Setup
clone https://github.com/SamiraArdani-NOAA/EVS.git
checkout branch feature/EVS-GLWU_move_STEP and set your HOMEevs to point to your local repository.
ln -sf /lfs/h2/emc/vpppg/noscrub/emc.vpppg/verification/EVS_fix/* fix/
In all driver scripts, Update the COMIN so that it points to the parallel outputs in emc.vpppg , evs_devonly:
export COMIN=/lfs/h2/emc/vpppg/noscrub/emc.vpppg/${NET}_devonly/${evs_ver_2d}
KEEPDATA set to YES
SENDMAIL set to NO
2- Execute the renamed J-jobs:

Prep: qsub $HOMEevs/dev/drivers/scripts/prep/glwu/jevs_prep_glwu_wave_grid2obs.sh

Stats: qsub $HOMEevs/dev/drivers/scripts/stats/glwu/jevs_stats_glwu_wave_grid2obs.sh

plots: qsub $HOMEevs/dev/drivers/scripts/plots/glwu/jevs_plots_glwu_wave_grid2obs_last31days.sh

plots: qsub $HOMEevs/dev/drivers/scripts/plots/glwu/jevs_plots_glwu_wave_grid2obs_last90days.sh

@malloryprow
Copy link
Contributor

I think the changes look good. Hopefully we can start testing on Monday!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update location of ${STEP} in GLWU scripts and filenames

4 participants