feature/EVS-GLWU_move_STEP#920
Open
SamiraArdani-NOAA wants to merge 3 commits intoNOAA-EMC:developfrom
Open
Conversation
Contributor
|
I think the changes look good. Hopefully we can start testing on Monday! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note to developers: You must use this PR template!
Description of Changes
This PR updates the EVS-GLWU naming conventions by moving the ${STEP} variable earlier in the filename (closes #917). In addition, the "last31days" plots were separated from "last90days" to align with the other operational components in EVS. Validation testing confirms the updates are functional for these changes.
Developer Questions and Checklist
No.
No.
No.
${USER}where necessary throughout the code.HOMEevsare removed from the code.dev/drivers/scriptsordev/modulefileshave been made in the correspondingecf/scriptsandecf/defs/evs-nco.def?Testing Instructions
Environment Setup
clone https://github.com/SamiraArdani-NOAA/EVS.git
checkout branch feature/EVS-GLWU_move_STEP and set your HOMEevs to point to your local repository.
ln -sf /lfs/h2/emc/vpppg/noscrub/emc.vpppg/verification/EVS_fix/* fix/
In all driver scripts, Update the COMIN so that it points to the parallel outputs in emc.vpppg , evs_devonly:
export COMIN=/lfs/h2/emc/vpppg/noscrub/emc.vpppg/${NET}_devonly/${evs_ver_2d}
KEEPDATA set to YES
SENDMAIL set to NO
2- Execute the renamed J-jobs:
Prep: qsub $HOMEevs/dev/drivers/scripts/prep/glwu/jevs_prep_glwu_wave_grid2obs.sh
Stats: qsub $HOMEevs/dev/drivers/scripts/stats/glwu/jevs_stats_glwu_wave_grid2obs.sh
plots: qsub $HOMEevs/dev/drivers/scripts/plots/glwu/jevs_plots_glwu_wave_grid2obs_last31days.sh
plots: qsub $HOMEevs/dev/drivers/scripts/plots/glwu/jevs_plots_glwu_wave_grid2obs_last90days.sh