Skip to content

Merge jcb-gdas into gdasapp #2038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DavidNew-NOAA merged 207 commits into from
Jan 20, 2026
Merged

Merge jcb-gdas into gdasapp #2038

DavidNew-NOAA merged 207 commits into from
Jan 20, 2026

Conversation

@DavidNew-NOAA
Copy link
Collaborator

@DavidNew-NOAA DavidNew-NOAA commented Jan 16, 2026 •
edited
Loading

Description

This PR merges the jcb-gdas repository into gdasapp. Importantly, the git history is retained. The client integration testing for the jcb-gdas repo is moved into the GitHub workflows for this repo.

This PR replaces #2031

Companion PRs

N/A

Issues

Automated CI tests to run in Global Workflow

  • atm_jjob
  • C96C48_ufs_hybatmDA
  • C96C48_hybatmsnowDA
  • C96_gcafs_cycled
  • C48mx500_3DVarAOWCDA
  • C48mx500_hybAOWCDA
  • C96C48_ufsgsi_hybatmDA
  • C96C48_hybatmDA

aerorahul and others added 30 commits February 28, 2024 13:31
@aerorahul
Initial commit
e5680cc
@danholdaway
Add some yaml files
a4d72ce
@danholdaway
Merge pull request #1 from NOAA-EMC/feature/work
a89be1a 
Add some yaml files
@danholdaway
add some gdas yamls
1e92234
@danholdaway
add berr files from gdasapp
26ccfca
@danholdaway
remove filters
72cd806
@danholdaway
3dvar looks to be working
f50c653
@danholdaway
add building blocks for ensemble da
811a74e
@danholdaway
reworking
e640beb
@danholdaway
reorder directory structure
2e0f57d
@danholdaway
rename to j2
0060c77
@danholdaway
j2
9bf50ef
@danholdaway
add observer chronicles
768a4e5
@danholdaway
update chron for amsua n19
5a71f17
@danholdaway
put all amsua n19 variables into chronicle
294b630
@danholdaway
Add obs YAMLS from gdas and create associated chronicles
3f280f0
@danholdaway
cris npp chronicle following jeff w
81426fc
@danholdaway
channels should not be a list
00cc73e
@danholdaway
add ps to background vars
3779636
@danholdaway
some chronicle fixes
73b43c1
@danholdaway
add option for writing increment to cubed sphere
a995274
@danholdaway
no chronicle for letkf
3f3cad4
@danholdaway
add avhrr satwind yamls
0c4af08
@danholdaway
Add the increment util
48a272d
@danholdaway
satwind bug
9050efc
@RussTreadon-NOAA
minor adjustments required by g-w JEDI ATM CI
f9c8576
@danholdaway
Merge pull request #2 from RussTreadon-NOAA/feature/jedi_atm_ci
96efdf7 
minor adjustments required by g-w JEDI ATM CI
@DavidNew-NOAA
Update
7a05a09
@DavidNew-NOAA
Initial commit
06582aa
@DavidNew-NOAA
Update output_ensemble_increments_cubed_sphere.yaml.j2
8fbbaa4
@emcbot
Copy link

emcbot commented Jan 17, 2026

Automated GW-GDASApp Testing Results:
Machine: hera

Start: Sat Jan 17 12:48:46 UTC 2026 on hfe10
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Sat Jan 17 13:09:34 UTC 2026
---------------------------------------------------
Tests: ctest -j12 -R gdasapp
Tests:                                 *SUCCESS*
Tests: Completed at Sat Jan 17 13:50:09 UTC 2026
Tests: 100% tests passed, 0 tests failed out of 144

@emcbot emcbot added hera-GW-RT-Passed Automated testing with global-workflow successful on Hera and removed hera-GW-RT-Running Automated testing with global-workflow running on Hera labels Jan 17, 2026
@emcbot
Copy link

emcbot commented Jan 17, 2026

Automated GW-GDASApp Testing Results:
Machine: orion

Start: Sat Jan 17 07:47:26 AM CST 2026 on orion-login-1.hpc.msstate.edu
---------------------------------------------------
Build:                                 *SUCCESS*
Build: Completed at Sat Jan 17 08:12:11 AM CST 2026
---------------------------------------------------
Tests: ctest -j12 -R gdasapp
Tests:                                 *SUCCESS*
Tests: Completed at Sat Jan 17 09:22:35 AM CST 2026
Tests: 100% tests passed, 0 tests failed out of 144

@emcbot emcbot added orion-GW-RT-Passed Automated testing with global-workflow successful on Orion and removed orion-GW-RT-Running Automated testing with global-workflow running on Orion labels Jan 17, 2026
RussTreadon-NOAA
RussTreadon-NOAA previously approved these changes Jan 17, 2026
View reviewed changes
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GDASApp ctests, including select g-w CI, Passed on Gaea C6, Hera, Orion, Ursa, and WCOSS2 (Dogwood). GDASApp ctests were not run on Hercules due to queue issues reported in ticket RDHPCS#2026011754000013.

Approve.

@RussTreadon-NOAA
Copy link
Contributor

RussTreadon-NOAA commented Jan 20, 2026 •
edited
Loading

@DavidNew-NOAA , we should be able to update this branch with develop at a9a6d12 and merge. I can re-approve if needed.

@RussTreadon-NOAA
Copy link
Contributor

RussTreadon-NOAA commented Jan 20, 2026

@DavidNew-NOAA and @CoryMartin-NOAA

Two items

  1. I will update the real-time JEDI parallel with these changes once this PR is merged into GDASApp develop.
  2. After this PR is closed, we should archive jcb-gdas to prevent developers from opening new issues and PRs in jcb-gdas. All jcb-gdas work needs to be done in GDASApp once this PR is merged into develop.

CoryMartin-NOAA
CoryMartin-NOAA previously approved these changes Jan 20, 2026
View reviewed changes
Copy link
Contributor

@CoryMartin-NOAA CoryMartin-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Archiving jcb-gdas makes sense to me. Just let me know if anyone thinks there should be any grace period between when this is merged and that occurs

@DavidNew-NOAA
Copy link
Collaborator Author

DavidNew-NOAA commented Jan 20, 2026

@CoryMartin-NOAA I think a grace period will only delay further development of gdasapp, since we don't want any more jcb-gdas PRs

RussTreadon-NOAA
RussTreadon-NOAA previously approved these changes Jan 20, 2026
View reviewed changes
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @DavidNew-NOAA for catching this. I totally forgot to check for .git* directories in parm/jcb-gdas.

Approve.

@DavidNew-NOAA
Copy link
Collaborator Author

DavidNew-NOAA commented Jan 20, 2026

@RussTreadon-NOAA There are copilot instructions in .github that Guillaume made for this repo that will have to be somehow integrated into the gdasapp instructions, but I will leave that for a later PR. They will be archived here in this PR.

@DavidNew-NOAA
Copy link
Collaborator Author

DavidNew-NOAA commented Jan 20, 2026

Nevermind, I was able to quickly edit the copilot instructions and place them in .github directory for GDASApp

@DavidNew-NOAA
Copy link
Collaborator Author

DavidNew-NOAA commented Jan 20, 2026

@RussTreadon-NOAA @CoryMartin-NOAA On your re-approval, I will merge

@RussTreadon-NOAA RussTreadon-NOAA self-requested a review January 20, 2026 14:52
RussTreadon-NOAA
RussTreadon-NOAA approved these changes Jan 20, 2026
View reviewed changes
Copy link
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

@DavidNew-NOAA DavidNew-NOAA merged commit acbd2bf into develop Jan 20, 2026
6 checks passed
@DavidNew-NOAA DavidNew-NOAA deleted the feature/merge-jcb-gdas branch January 20, 2026 14:54
@DavidNew-NOAA DavidNew-NOAA mentioned this pull request Jan 20, 2026
Merged
DavidNew-NOAA added a commit that referenced this pull request Jan 20, 2026
@DavidNew-NOAA
Uncomment line from jcb client testing workflow (#2039)
c30d56c 
# Description

I forgot to uncomment a line in the JCB-GDAS client testing GitHub
Workflow when I was testing
#2038 . This uncomments that
line.

# Companion PRs

<!-- Enter links to any companion PRs here. -->

# Issues

<!-- Enter any issues referenced or resolved by this PR here. Use
keywords "Resolves" or "Refs".
Resolves #1234
Refs #4321
Refs NOAA-EMC/repo#5678
-->

# Automated CI tests to run in Global Workflow
JCB-GDAS client testing workflow
@RussTreadon-NOAA RussTreadon-NOAA mentioned this pull request Jan 20, 2026
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA approved these changes

@RussTreadon-NOAA RussTreadon-NOAA RussTreadon-NOAA approved these changes

Assignees

@DavidNew-NOAA DavidNew-NOAA

Labels

gaeac6-GW-RT-Passed hera-GW-RT-Passed Automated testing with global-workflow successful on Hera orion-GW-RT-Passed Automated testing with global-workflow successful on Orion ursa-GW-RT-Passed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.