Skip to content

Conversation

@sanAkel
Copy link
Contributor

@sanAkel sanAkel commented Jan 9, 2026

This PR removes HYCOM_tools as a submodule of RTOFS_GLO. Why?

See ⬇️ that has been copy/pasted from #98 (comment)

Here is the major problem:

  1. I'm looking into the code delivery requirements. We already have a few bugzilla issues and one of them calls for removal of about 230 go to statements.
  2. If we keep the submodule HYCOM_tools.fd at sorc then
  3. It will add 2402 go to statements! 😢
santha.akella@dlogin02:~> cd my_stmp
santha.akella@dlogin02:~/my_stmp> ls
santha.akella@dlogin02:~/my_stmp> git clone [email protected]:HYCOM/HYCOM-tools.git
Cloning into 'HYCOM-tools'...
remote: Enumerating objects: 2357, done.
remote: Counting objects: 100% (234/234), done.
remote: Compressing objects: 100% (134/134), done.
remote: Total 2357 (delta 134), reused 115 (delta 98), pack-reused 2123 (from 1)
Receiving objects: 100% (2357/2357), 4.23 MiB | 17.00 MiB/s, done.
Resolving deltas: 100% (1408/1408), done.
Updating files: 100% (1541/1541), done.
santha.akella@dlogin02:~/my_stmp> ls
HYCOM-tools
santha.akella@dlogin02:~/my_stmp> cd HYCOM-tools/

See ⬇️

santha.akella@dlogin02:~/my_stmp/HYCOM-tools> grep -rEi "go\s*to" . | wc -l
2402
  1. To avoid trouble, we should really remove the HYCOM_tools submodule.

The only reference(s) to HYCOM_tools is in scripts/to_revive_hycom/ which can be deleted once RTOFS v3 is declared operational.

@sanAkel sanAkel self-assigned this Jan 9, 2026
@sanAkel sanAkel added v3-dev Development for RTOFS v3 Ready to merge Tested and works labels Jan 9, 2026
@sanAkel sanAkel merged commit 961baf1 into develop Jan 13, 2026
@sanAkel sanAkel deleted the remove_hycom_tools branch January 13, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge Tested and works v3-dev Development for RTOFS v3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants