Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove early-cycle EnKF forecast #3185

Merged
merged 2 commits into from
Dec 26, 2024
Merged

Remove early-cycle EnKF forecast #3185

merged 2 commits into from
Dec 26, 2024

Conversation

TravisElless-NOAA
Copy link
Contributor

@TravisElless-NOAA TravisElless-NOAA commented Dec 20, 2024 •
edited
Loading

Description

Currently GFS experiments with the early-cycle EnKF call identical jobs to the late-cycle. However, since the forecast portion of the early-cycle is handled through the GEFS workflow, the forecast and post jobs are not needed in the GFS early-cycle EnKF. This PR removes calling the early-cycle EnFK forecast and post jobs in GFS experiments, and adds statements to the archive yamls to only search for forecast files during the late-cyle EnKF.

Type of change

  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

  • Cycled test on Hera

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing tests pass with my changes

aerorahul
aerorahul approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules label Dec 25, 2024
@emcbot emcbot added CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully and removed CI-Hercules-Ready **CM use only** PR is ready for CI testing on Hercules CI-Hercules-Building **Bot use only** CI testing is cloning/building on Hercules CI-Hercules-Running **Bot use only** CI testing on Hercules for this PR is in-progress labels Dec 25, 2024
@emcbot
Copy link

emcbot commented Dec 25, 2024

CI Passed on Hercules in Build# 1
Built and ran in directory /work2/noaa/global/CI/HERCULES/3185


Experiment C48_ATM_1fe6fb75 Completed 2 Cycles: *SUCCESS* at Tue Dec 24 23:25:17 CST 2024
Experiment C48mx500_3DVarAOWCDA_1fe6fb75 Completed 2 Cycles: *SUCCESS* at Tue Dec 24 23:25:24 CST 2024
Experiment C48mx500_hybAOWCDA_1fe6fb75 Completed 2 Cycles: *SUCCESS* at Tue Dec 24 23:31:37 CST 2024
Experiment C96_S2SWA_gefs_replay_ics_1fe6fb75 Completed 1 Cycles: *SUCCESS* at Wed Dec 25 00:14:34 CST 2024
Experiment C96C48_hybatmDA_1fe6fb75 Completed 3 Cycles: *SUCCESS* at Wed Dec 25 00:26:12 CST 2024
Experiment C96_atm3DVar_1fe6fb75 Completed 3 Cycles: *SUCCESS* at Wed Dec 25 00:32:05 CST 2024
Experiment C48_S2SW_1fe6fb75 Completed 2 Cycles: *SUCCESS* at Wed Dec 25 01:27:01 CST 2024
Experiment C48_S2SWA_gefs_1fe6fb75 Completed 1 Cycles: *SUCCESS* at Wed Dec 25 01:44:29 CST 2024

@WalterKolczynski-NOAA WalterKolczynski-NOAA merged commit 1c37f90 into NOAA-EMC:develop Dec 26, 2024
10 of 11 checks passed
This was referenced Dec 26, 2024
Closed
Merged
aerorahul pushed a commit that referenced this pull request Jan 3, 2025
@RussTreadon-NOAA
Add efcs and epos to ufs_hybatm xml (#3192) (#3193)
da9d717 
# Description
g-w PR #3185 inadvertently removed metatasks enkfgdas_fcst and
enkfgdas_epmn from the ufs_hybatmDA xml. This PR modifies
`workflow/applications/gfs_cycled.py` so that these metatasks are once
again in the ufs_hybatmDA xml.

Resolves: #3192
tsga added a commit to tsga/global-workflow that referenced this pull request Jan 4, 2025
@tsga
Merge branch 'develop' into feature/lnd_regrid_iau
066f60f 
* develop:
  Ensure OCNRES and ICERES have 3 digits in the archive script (NOAA-EMC#3199)
  Set runtime shell requirements within Jenkins Pipeline (NOAA-EMC#3171)
  Add efcs and epos to ufs_hybatm xml (NOAA-EMC#3192) (NOAA-EMC#3193)
  Fix GEFS and SFS compile flags in build_all.sh (NOAA-EMC#3197)
  Remove early-cycle EnKF forecast (NOAA-EMC#3185)
  Fix mod_icec bug in atmos_prod (NOAA-EMC#3167)
  Create compute build option (NOAA-EMC#3186)
  Support global-workflow using Rocky 8 on CSPs (NOAA-EMC#2998)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WalterKolczynski-NOAA WalterKolczynski-NOAA WalterKolczynski-NOAA approved these changes

@aerorahul aerorahul aerorahul approved these changes

@DavidHuber-NOAA DavidHuber-NOAA Awaiting requested review from DavidHuber-NOAA DavidHuber-NOAA is a code owner

Assignees
No one assigned
Labels
CI-Hercules-Passed **Bot use only** CI testing on Hercules for this PR has completed successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@TravisElless-NOAA @emcbot @aerorahul @WalterKolczynski-NOAA