Process aerosol analysis in grib2 format via UPP in GCAFS #4234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ypwang19
requested review from
CatherineThomas-NOAA,
CoryMartin-NOAA,
DavidHuber-NOAA,
RussTreadon-NOAA and
aerorahul
as code owners
Co-authored-by: Cory Martin <[email protected]>
CoryMartin-NOAA
previously approved these changes
Nov 19, 2025
Contributor
|
@ypwang19 I think you need to merge in develop and resolve any conflicts, thanks! |
CoryMartin-NOAA
previously approved these changes
Dec 30, 2025
Contributor
|
Do we need anything else or is this ready for test and final review? |
CoryMartin-NOAA
previously approved these changes
Jan 2, 2026
| - "{{ COMIN_ATMOS_GRIB_0p50 | relpath(ROTDIR) }}/{{ head }}pres_a.0p50.analysis.grib2.idx" | ||
| - "{{ COMIN_ATMOS_GRIB_1p00 | relpath(ROTDIR) }}/{{ head }}pres_a.1p00.analysis.grib2" | ||
| - "{{ COMIN_ATMOS_GRIB_1p00 | relpath(ROTDIR) }}/{{ head }}pres_a.1p00.analysis.grib2.idx" | ||
| # temporarily disable pres_b products archiving. |
Contributor
There was a problem hiding this comment.
@bbakernoaa note this for when we get your previous PR un-reverted
Contributor
TravisElless-NOAA
left a comment
TravisElless-NOAA
left a comment
There was a problem hiding this comment.
Just a few minor suggestions from me.
dev/jobs/JGLOBAL_ATMOS_ANALYSIS_CALC
Outdated
Comment on lines
33
to
34
| COMIN_ATMOS_RESTART:COM_ATMOS_RESTART_TMPL \ | ||
| COMIN_CHEM_ANALYSIS:COM_CHEM_ANALYSIS_TMPL |
Contributor
There was a problem hiding this comment.
Since this is only used for the GCAFS system probably best to put this into an if statement and only call for that system.
Co-authored-by: Travis Elless <[email protected]>
Co-authored-by: Travis Elless <[email protected]>
TravisElless-NOAA
requested changes
Jan 6, 2026
Contributor
|
Will launch Hera CI |
emcbot
added
CI-Hera-Ready
Co-authored-by: Travis Elless <[email protected]>
TravisElless-NOAA
approved these changes
Jan 6, 2026
emcbot
added
CI-Hera-Running
Contributor
|
Sorry for my delay on this @ypwang19. Since the Hera tests passed, I will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves issue ##4233
This PR adds the capability to process analysis tracer fields into aerosol AOD product in GRIB2 format using the upp tool within the GCAFS workflow. The input for UPP is aerosol analysis on Gaussian grid. Aerosol variables in atmospheric analysis file (
analysis.atm.a006.nc) are all missing data, such that the aerosol Gaussian tracer analysis fields are generated by adding aerosol increments (aeroinc_gaussian) to theatm.f006background file.This feature is implemented in
analcalc,atmanlupp, andatmanlprodjobs in GCAFS workflow.This PR depends on parm/product/gcafs* files, such that it will work after #4147 merged.
Resolves #4233
Dependency
PR #4147
Type of change
Change characteristics
How has this been tested?
Checklist