Skip to content

Enable to read IMS data in ascii or netcdf format #4387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jiaruidong2017 wants to merge 7 commits into from
Closed

Enable to read IMS data in ascii or netcdf format #4387

jiaruidong2017 wants to merge 7 commits into from
+12 −13

Conversation

@jiaruidong2017
Copy link
Contributor

@jiaruidong2017 jiaruidong2017 commented Dec 28, 2025 •
edited
Loading

Description

This PR enables to read and process the input IMS snow cover data in either ascii or netCDF format.

Resolves NOAA-EMC/GDASApp#2022

Type of change

  • New feature (adds functionality)

Change characteristics

  • Is this change expected to change outputs (e.g. value changes to existing outputs, new files stored in COM, files removed from COM, filename changes, additions/subtractions to archives)? NO
  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? YES

How has this been tested?

I conducted cycled experiments with DO_JEDISNOWDA=YES. These runs also require IMS snow cover observations in netCDF format.

  • Cycled test on Ursa

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@jiaruidong2017 jiaruidong2017 self-assigned this Dec 28, 2025
@jiaruidong2017 jiaruidong2017 mentioned this pull request Dec 28, 2025
Merged
8 tasks
@jiaruidong2017 jiaruidong2017 added the JEDI Feature development to support JEDI-based DA label Dec 28, 2025
ClaraDraper-NOAA
ClaraDraper-NOAA reviewed Dec 29, 2025
View reviewed changes
@jiaruidong2017 jiaruidong2017 mentioned this pull request Dec 30, 2025
Closed
CoryMartin-NOAA
CoryMartin-NOAA reviewed Jan 2, 2026
View reviewed changes
CoryMartin-NOAA pushed a commit to NOAA-EMC/GDASApp that referenced this pull request Jan 2, 2026
@jiaruidong2017
Enable to read and process the IMS data in netcdf format (#2023)
e563476 
# Description

The current C++ IMS preprocessing code supports only ASCII-format input
files. This PR adds support for netCDF input files to meet the
requirements of reanalysis projects.

Contributes to NOAA-EMC/global-workflow#4387

# Companion PRs
NOAA-EMC/jcb-gdas#221

# Issues

Resolves #2022 

# Automated CI tests to run in Global Workflow
<!-- Which Global Workflow CI tests are required to adequately test this
PR? -->
- [ ] atm_jjob <!-- JEDI atm single cycle DA !-->
- [ ] C96C48_ufs_hybatmDA <!-- JEDI atm cycled DA !-->
- [ ] C96C48_hybatmsnowDA <!-- JEDI snow cycled DA !-->
- [ ] C96_gcafs_cycled <!-- JEDI aerosol cycled DA !-->
- [ ] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !-->
- [ ] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !-->
- [ ] C96C48_ufsgsi_hybatmDA <!-- JEDI atm Var with GSI EnKF cycled DA
!-->
- [ ] C96C48_hybatmDA <!-- GSI atm cycled DA !-->
@RussTreadon-NOAA
Copy link
Contributor

RussTreadon-NOAA commented Jan 2, 2026

@jiaruidong2017 : The PR updates the GDASApp hash to gdas.cd @ e563476. This is fine, but since this hash is after GDASApp develop at 89e4101, we need to update sorc/link_workflow.sh in jiaruidong2017:feature/ims_nc. The change is simple. Just remove the line

 cp -f "${HOMEgfs}/sorc/gdas.cd/install/bin/calcfIMS.exe" ./gdas_calcfIMS.x

from link_workflow.sh. Failure to update link_workflow.sh will cause link_workflow.sh to abort prematurely and g-w CI will fail.

See g-w issue #4398 for details.

@jiaruidong2017
Copy link
Contributor Author

jiaruidong2017 commented Jan 2, 2026

Thanks @RussTreadon-NOAA for the reminder and I will include this.

jiaruidong2017 added a commit to jiaruidong2017/global-workflow that referenced this pull request Jan 2, 2026
@jiaruidong2017
Merge PR NOAA-EMC#4387 into this PR
f2c6847
@jiaruidong2017
Copy link
Contributor Author

jiaruidong2017 commented Jan 2, 2026

This PR has been merged into PR #4386

@jiaruidong2017 jiaruidong2017 mentioned this pull request Jan 2, 2026
Closed
14 tasks
DavidNew-NOAA pushed a commit to NOAA-EMC/GDASApp that referenced this pull request Jan 16, 2026
@jiaruidong2017
Enable to read and process the IMS data in netcdf format (#2023)
2ec79ec 
# Description

The current C++ IMS preprocessing code supports only ASCII-format input
files. This PR adds support for netCDF input files to meet the
requirements of reanalysis projects.

Contributes to NOAA-EMC/global-workflow#4387

# Companion PRs
NOAA-EMC/jcb-gdas#221

# Issues

Resolves #2022 

# Automated CI tests to run in Global Workflow
<!-- Which Global Workflow CI tests are required to adequately test this
PR? -->
- [ ] atm_jjob <!-- JEDI atm single cycle DA !-->
- [ ] C96C48_ufs_hybatmDA <!-- JEDI atm cycled DA !-->
- [ ] C96C48_hybatmsnowDA <!-- JEDI snow cycled DA !-->
- [ ] C96_gcafs_cycled <!-- JEDI aerosol cycled DA !-->
- [ ] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !-->
- [ ] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !-->
- [ ] C96C48_ufsgsi_hybatmDA <!-- JEDI atm Var with GSI EnKF cycled DA
!-->
- [ ] C96C48_hybatmDA <!-- GSI atm cycled DA !-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CoryMartin-NOAA CoryMartin-NOAA CoryMartin-NOAA left review comments

@ClaraDraper-NOAA ClaraDraper-NOAA ClaraDraper-NOAA left review comments

@DavidNew-NOAA DavidNew-NOAA Awaiting requested review from DavidNew-NOAA DavidNew-NOAA is a code owner

@DavidHuber-NOAA DavidHuber-NOAA Awaiting requested review from DavidHuber-NOAA DavidHuber-NOAA is a code owner

@aerorahul aerorahul Awaiting requested review from aerorahul aerorahul is a code owner

Assignees

@jiaruidong2017 jiaruidong2017

Labels

JEDI Feature development to support JEDI-based DA

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable IMS preprocessing support for netCDF input files

4 participants

@jiaruidong2017 @RussTreadon-NOAA @CoryMartin-NOAA @ClaraDraper-NOAA