This repository was archived by the owner on Jan 20, 2026. It is now read-only.
Add option to override all filters with a global setting #213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoryMartin-NOAA
approved these changes
Dec 5, 2025
Contributor
CoryMartin-NOAA
left a comment
CoryMartin-NOAA
left a comment
There was a problem hiding this comment.
GOES-16, great choice! :-)
There was a problem hiding this comment.
Pull request overview
This PR adds a new JCB-level configuration option to globally override observation filters, serving as a companion implementation to NOAA-EMC/jcb#31. The change demonstrates how to replace all filters for a specific observation type (GOES-16 ABI) with a custom filter set.
Key Changes
- Introduces
replace_obs_filtersconfiguration block with observation list and override filter definitions - Applies to
abi_g16observations as an example implementation - Adds PreQC filter with rejection action based on maxvalue threshold
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The companion PR to NOAA-EMC/jcb#31 offering an example of how to apply the change to just the GOES-16 ABI YAML.