Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

Conversation

@jiaruidong2017
Copy link
Contributor

@jiaruidong2017 jiaruidong2017 commented Dec 28, 2025

Update the input file suffixes from .asc to .dat, including those for ASCII and NetCDF formats.

Contributes to NOAA-EMC/GDASApp#2023

Copy link

@ClaraDraper-NOAA ClaraDraper-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to keep the original suffix to make it easier to trace the filetype, but I see that this is consistent with the IMS proc code testing the file type, so I'll defer to how @CoryMartin-NOAA would like to handle it.

@CoryMartin-NOAA
Copy link
Contributor

What is the suffix of the file in the dump directory? Is it asc? I would also prefer it to be reflective of what the format is.

@jiaruidong2017
Copy link
Contributor Author

What is the suffix of the file in the dump directory? Is it asc? I would also prefer it to be reflective of what the format is.

The ASCII file in dump directory uses the .asc extension. For reanalysis project, they prefer to use NetCDF format with the .nc extension.

@CoryMartin-NOAA
Copy link
Contributor

Ok so lets either do something like:

input scf file: './obs/ims{{ snow_background_time_julian }}_4km_v1.3{ims_snow_suffix}'

or

{% if use_ims_nc %}
input scf file: './/obs/ims{{ snow_background_time_julian }}_4km_v1.3.nc'
{% else if %}
input scf file: './/obs/ims{{ snow_background_time_julian }}_4km_v1.3.asc'
{% end if %}

The top one will be easier to implement

@CoryMartin-NOAA CoryMartin-NOAA merged commit b83769d into develop Jan 2, 2026
1 check passed
@CoryMartin-NOAA CoryMartin-NOAA deleted the feature/ims_nc branch January 2, 2026 18:08
CoryMartin-NOAA pushed a commit to NOAA-EMC/GDASApp that referenced this pull request Jan 2, 2026
# Description

The current C++ IMS preprocessing code supports only ASCII-format input
files. This PR adds support for netCDF input files to meet the
requirements of reanalysis projects.

Contributes to NOAA-EMC/global-workflow#4387

# Companion PRs
NOAA-EMC/jcb-gdas#221

# Issues

Resolves #2022 

# Automated CI tests to run in Global Workflow
<!-- Which Global Workflow CI tests are required to adequately test this
PR? -->
- [ ] atm_jjob <!-- JEDI atm single cycle DA !-->
- [ ] C96C48_ufs_hybatmDA <!-- JEDI atm cycled DA !-->
- [ ] C96C48_hybatmsnowDA <!-- JEDI snow cycled DA !-->
- [ ] C96_gcafs_cycled <!-- JEDI aerosol cycled DA !-->
- [ ] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !-->
- [ ] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !-->
- [ ] C96C48_ufsgsi_hybatmDA <!-- JEDI atm Var with GSI EnKF cycled DA
!-->
- [ ] C96C48_hybatmDA <!-- GSI atm cycled DA !-->
DavidNew-NOAA pushed a commit to NOAA-EMC/GDASApp that referenced this pull request Jan 16, 2026
# Description

The current C++ IMS preprocessing code supports only ASCII-format input
files. This PR adds support for netCDF input files to meet the
requirements of reanalysis projects.

Contributes to NOAA-EMC/global-workflow#4387

# Companion PRs
NOAA-EMC/jcb-gdas#221

# Issues

Resolves #2022 

# Automated CI tests to run in Global Workflow
<!-- Which Global Workflow CI tests are required to adequately test this
PR? -->
- [ ] atm_jjob <!-- JEDI atm single cycle DA !-->
- [ ] C96C48_ufs_hybatmDA <!-- JEDI atm cycled DA !-->
- [ ] C96C48_hybatmsnowDA <!-- JEDI snow cycled DA !-->
- [ ] C96_gcafs_cycled <!-- JEDI aerosol cycled DA !-->
- [ ] C48mx500_3DVarAOWCDA <!-- JEDI low-res marine 3DVar cycled DA !-->
- [ ] C48mx500_hybAOWCDA <!-- JEDI marine hybrid envar cycled DA !-->
- [ ] C96C48_ufsgsi_hybatmDA <!-- JEDI atm Var with GSI EnKF cycled DA
!-->
- [ ] C96C48_hybatmDA <!-- GSI atm cycled DA !-->
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants