Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

Conversation

@jianjunj
Copy link
Contributor

@jianjunj jianjunj commented Mar 26, 2025

Quality control and bias correction configurations to assimilate GPM GMI data in all-sky conditions. The related issue is NOAA-EMC/GDASApp#1537 .

Dependencies

List the other PRs that this PR is dependent on:

@jianjunj jianjunj self-assigned this Mar 26, 2025
@jianjunj jianjunj added draft draft PR often used for discussion and removed DO NOT MERGE labels Mar 26, 2025
Copy link
Contributor

@emilyhcliu emilyhcliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@jianjunj
Copy link
Contributor Author

jianjunj commented Apr 7, 2025

This. PR depends on two UFO PRs. One updates the GMI clouds index retrieval referring to algorithm used in GFS and the other one adds an optional input "absolute threshold vector" in the Background Check filter, which enables us to read the maximum observational errors from the observation_chronicle tables.

@jianjunj jianjunj removed the draft draft PR often used for discussion label Apr 7, 2025
@DavidNew-NOAA
Copy link
Contributor

@jianjunj Is this PR still in active development? I am planning on merging jcb-gdas into the gdasapp repo, and I'm trying to figure out which jcb-gdas PRs can be merged quickly. If this PR cannot be merged quickly, it will have to become a gdasapp PR.

@jianjunj
Copy link
Contributor Author

jianjunj commented Jan 8, 2026

@DavidNew-NOAA Let me check whether these updates still stand.

@RussTreadon-NOAA
Copy link
Contributor

@jianjunj : What is the status of this PR? We can not move forward with GDASApp PR #2031 until this PR is either (a) merged into jcb-gdas develop or (b) closed without action.

Tagging @DavidNew-NOAA and @CoryMartin-NOAA for awareness.

@jianjunj
Copy link
Contributor Author

@DavidNew-NOAA @RussTreadon-NOAA Just let you know I am making some minor update right now. Will get back to you soon.

@RussTreadon-NOAA
Copy link
Contributor

@jianjunj and @DavidNew-NOAA

This PR adds two new files

  • observation_chronicle/atmosphere/gmi_gpm.yaml
  • observations/atmosphere/gmi_gpm.yaml.j2

Given this, we could

  1. close this PR
  2. get GDASApp PR #2031 into GDASApp develop
  3. open a GDASApp PR to merge the above gmi_gpm files into GDASApp parm/jcb-gdas.

What do you think?

@jianjunj
Copy link
Contributor Author

@RussTreadon-NOAA @DavidNew-NOAA This PR can be merged now.

@RussTreadon-NOAA
Copy link
Contributor

@jianjunj : Can you confirm that merger of this PR into jcb-gdas develop will not break anything in GDASApp develop? We can merge given your confirmation.

@DavidNew-NOAA
Copy link
Contributor

@RussTreadon-NOAA This PR is just adding an observation which I'm assuming isn't turned on in any of our obs lists anywhere, since until this PR, no YAML has existed for that observation. I think we can be fairly confident that nothing will break.

@RussTreadon-NOAA
Copy link
Contributor

I entirely agree, @DavidNew-NOAA. Just wanting to @jianjunj to chime in as the developer responsible for these changes.

Thank you for updating his branch with develop. Let's merge so you can keep moving forward.

@DavidNew-NOAA
Copy link
Contributor

Will merge now. Thanks @jianjunj and @RussTreadon-NOAA

@DavidNew-NOAA DavidNew-NOAA merged commit e177e61 into develop Jan 16, 2026
1 check passed
@DavidNew-NOAA DavidNew-NOAA deleted the feature/microwave_allsky_gmi branch January 16, 2026 18:40
@jianjunj
Copy link
Contributor Author

@RussellManser-NCO I didn't expect that since it didn't activate the assimilation of GMI data. Since I was wrong before, however, I am running these ctests now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

6 participants