-
Notifications
You must be signed in to change notification settings - Fork 10
Configurations to assimilate GPM GMI data in all-sky. #90
Conversation
…ected "err1" and "err2".
…Added the data thinning filter.
emilyhcliu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good.
|
This. PR depends on two UFO PRs. One updates the GMI clouds index retrieval referring to algorithm used in GFS and the other one adds an optional input "absolute threshold vector" in the Background Check filter, which enables us to read the maximum observational errors from the observation_chronicle tables. |
|
@jianjunj Is this PR still in active development? I am planning on merging jcb-gdas into the gdasapp repo, and I'm trying to figure out which jcb-gdas PRs can be merged quickly. If this PR cannot be merged quickly, it will have to become a gdasapp PR. |
|
@DavidNew-NOAA Let me check whether these updates still stand. |
|
@jianjunj : What is the status of this PR? We can not move forward with GDASApp PR #2031 until this PR is either (a) merged into jcb-gdas Tagging @DavidNew-NOAA and @CoryMartin-NOAA for awareness. |
|
@DavidNew-NOAA @RussTreadon-NOAA Just let you know I am making some minor update right now. Will get back to you soon. |
|
This PR adds two new files
Given this, we could
What do you think? |
|
@RussTreadon-NOAA @DavidNew-NOAA This PR can be merged now. |
|
@jianjunj : Can you confirm that merger of this PR into jcb-gdas |
|
@RussTreadon-NOAA This PR is just adding an observation which I'm assuming isn't turned on in any of our obs lists anywhere, since until this PR, no YAML has existed for that observation. I think we can be fairly confident that nothing will break. |
|
I entirely agree, @DavidNew-NOAA. Just wanting to @jianjunj to chime in as the developer responsible for these changes. Thank you for updating his branch with |
|
Will merge now. Thanks @jianjunj and @RussTreadon-NOAA |
|
@RussellManser-NCO I didn't expect that since it didn't activate the assimilation of GMI data. Since I was wrong before, however, I am running these ctests now. |
Quality control and bias correction configurations to assimilate GPM GMI data in all-sky conditions. The related issue is NOAA-EMC/GDASApp#1537 .
Dependencies
List the other PRs that this PR is dependent on: