Remove some of the algorithms that fail the ci testing.#2
Merged
delippi merged 1 commit intoNOAA-EMC:developfrom Sep 3, 2025
Merged
Remove some of the algorithms that fail the ci testing.#2delippi merged 1 commit intoNOAA-EMC:developfrom
delippi merged 1 commit intoNOAA-EMC:developfrom
Conversation
Collaborator
Author
|
@CoryMartin-NOAA I think will fix CI failures in NOAA-EMC/jcb#30. |
CoryMartin-NOAA
approved these changes
Sep 2, 2025
Collaborator
|
Thanks @delippi |
Collaborator
Author
|
@CoryMartin-NOAA, I just merged this. Do you want to retry the https://github.com/NOAA-EMC/jcb CI tests? Hopefully this will fix it. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is meant to fix the failing CI tests in NOAA-EMC/jcb#30.
The
supported_algorithms: hofx4d, and locaal_ensemble_da were not working. Additionally, the local algorithms fv3jedi_fv3inc_lgetkf and fv3jedi_fv3inc_variational have not yet been jinja-fied and more testing will be needed.