Re-set the default number of not_bias_corrected channels #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoryMartin-NOAA
approved these changes
Jun 26, 2025
danholdaway
approved these changes
Jul 15, 2025
CoryMartin-NOAA
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @emilyhcliu 's discovery that the default number of "-999" for not_bias_corrected channels confused UFO weeks ago. The reason is that the dash sign "-" is configured in channels numbers such as "10-20" in UFO, and then wrong channel indices can be returned when "-999" is searched in UFO. Propose to re-set the default number as "99999". @emilyhcliu 's tests confirmed that it could fix the issue.