Allow JCB apps to be subdirectories of larger repos for GitHub CI purposes #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidNew-NOAA
changed the title
CoryMartin-NOAA
approved these changes
Jan 7, 2026
danholdaway
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies JCB client integration testing to allow for JCB apps to be subdirectories of larger repositories rather than stand-alone repositories. This will allow the merger of
jcb-gdasintogdasappwhile moving JCB client integration testing into thegdasapprepo on GitHub.A new optional key, 'app_subdir', is now permitted in
jcb_clients.yamlthat indicates the relative path of the JCB app in its parent repo.I tested these changes in two ways:
jcb-gdasPR, Test jcb-gdas#226 , setting thejcbrepo branch for GitHub CI testing to this branch. GitHub CI passes successfully.gdasappPR, Merge jcb-gdas into gdasapp GDASApp#2031, that mergedjcb-gdasintogdasappas a subdirectory of that repo, and with the GitHub CI workflows forjcb-gdasintogdasapp. Again, I set the jcb` repo branch for GitHub CI testing to this branch, and it passes CI successly.