Display any HTML in the "alert_message" setting #1311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Allows the alert_message configuration value to render trusted raw HTML (e.g.,
, ) in the shutdown banner.
- Added a template helper (displayAsRawHTML) returning template.HTML and registered it with Gin.
- Updated alert.html to pipe AlertMessage through the new helper for unescaped rendering.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| home/main.go | Adds displayAsRawHTML helper and registers it in the Gin template func map. |
| home/templates/alert.html | Uses the new helper to render the configured alert message as raw HTML. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
The latest shutdown banner needed some HTML formatting to enable <br> and <a> tags. The easiest way forward is to allow raw HTML in that config file. This should be safe, as we control the settings.
ian-noaa
force-pushed
the
support-html-in-alerts
branch
from
44608a2 to
b75ad48
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mollybsmith-noaa
approved these changes
Oct 1, 2025
Collaborator
mollybsmith-noaa
left a comment
mollybsmith-noaa
left a comment
There was a problem hiding this comment.
Looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest shutdown banner needed some HTML formatting to enable
<br>and<a>tags. The easiest way forward is to allow raw HTML in that config file. This should be safe, as we control the settings.