Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor updates to documentation files #451

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

robertbartel
Copy link
Contributor

A few fixes (e.g., typos), refinements, and updates to the ./doc/GIT_USAGE.md and ./INSTALL.md documentation files.

@robertbartel robertbartel added documentation Improvements or additions to documentation maas MaaS Workstream labels Oct 12, 2023
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a blurb about setting up a PR on here? Maybe something mentioning preferred uses of draft PRs for easier collaboration?

Something saying that github tests should pass before approving PRs (except for extenuating circumstances, such as upstream dependency issues at the time of writing) and something saying that "Rebase and Merge" button should be clicked instead of just the standard "Merge" button and where to find it.

If you say no I'll go ahead and approve anyways.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made another issue for it in our board. We may not have time to get to that before things next week, but I'll convert unfinished any such things to full issues and keep them on the project board.

@robertbartel robertbartel merged commit bf77468 into NOAA-OWP:master Oct 13, 2023
1 check failed
@robertbartel robertbartel deleted the i/docs_oct_2023/main branch October 13, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation maas MaaS Workstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants