Ensure memory can be set for requested jobs #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also updating related tests.
Ensure that SchedulerRequestMessage uses (if available) the memory value of its provided model_request property if an explicit memory param is not given; also, update related tests for this and previous change to put "memory" in model requests.
To ensure updated DmodJobRequest with "memory" attribute is used.
christophertubbs
approved these changes
May 16, 2024
There was a problem hiding this comment.
Looks good. The only thing that concerns me is asserting equal to strings in the to_json tests. You might be better off by taking those strings, converting them to dicts via json.loads and comparing the results. This will ensure that the json does what you want it to, that it serializes and deserializes correctly, and order of keys never becomes an issue.
|
In taking a quick look at this, I know the 500Kb default memory limit originates elsewhere, but we should really raise that default value. I suggest something like 128, 256, or 512MiB instead or even higher. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating request objects and CLI to make sure that
memorycan be explicitly provided when requesting a job.