Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RealizationConfigDomainDetector file opening #622

Conversation

robertbartel
Copy link
Contributor

Fixing bug in opening of file to deserialize it for domain detection. Also adding unit tests for this class.

Fix bug with opening the realization config file itself when
deserializing.
@robertbartel robertbartel added bug Something isn't working maas MaaS Workstream labels May 17, 2024
Copy link
Contributor

@christophertubbs christophertubbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

roll tide on those unit tests.

@christophertubbs christophertubbs merged commit 417ea09 into NOAA-OWP:master May 17, 2024
8 checks passed
@robertbartel robertbartel deleted the bug/real_config_domain_detector_fix_open/main branch May 17, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maas MaaS Workstream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants