Mapx dtype updates #1010
Merged
Mapx dtype updates #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #995 and #994
Adds a Jupyter Notebook script that compares the mapx files to the database tables they reference and updates the dtypes of the mapx accordingly. This commit also includes all of the mapx files that were updated on the initial execution of the script.
It would be great to have this type of script be able to run automatically as a CI/CD workflow whenever a PR is submitted. But for now, I recommend that we add running this script to our deployment checklist as another manual execution. The execution results in modified mapx files, which should then be committed to a new branch, pushed, and opened as a PR.