Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make image for update-egis-db #1055

Merged
merged 13 commits into from
Feb 11, 2025
Merged

Conversation

groutr
Copy link
Contributor

@groutr groutr commented Jan 22, 2025

The current LAMBDA uses AWS layers to manage dependencies. This PR switches to an image-based LAMBDA for better environment isolation/management.

ref: #1029

@shawncrawley
Copy link
Collaborator

Rather than update the terraform code for the update-egis-db function in-place in the Core/LAMBDA/viz_functions/main.tf file, I would like you to nest this as needed within the Core/LAMBDA/viz_functions/image_based/ folder, since we're converting it to an image-based Lambda (i.e. a Lambda based on a Docker image). I'll further ask that you follow the Terraform pattern that I used for `Core/LAMBDA/viz_functions/image_based/viz_schism_fim_processing, which was my first iteration and example of what I intend to eventually do for every Lambda as captured in issue #945. If you need some more context and guidance for this, please let me know.

@groutr groutr force-pushed the update-egis-db-image branch from 1b282a6 to 4e9149b Compare January 27, 2025 16:08
@groutr groutr marked this pull request as ready for review January 30, 2025 17:57
@groutr
Copy link
Contributor Author

groutr commented Jan 30, 2025

@shawncrawley I think this is ready for review.

@shawncrawley shawncrawley merged commit 3b17070 into NOAA-OWP:ti Feb 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants