Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added HFM to Public FIM as Sublayers #1082

Open
wants to merge 1 commit into
base: ti
Choose a base branch
from

Conversation

GeorgeRought-NOAA
Copy link
Contributor

@GeorgeRought-NOAA GeorgeRought-NOAA commented Feb 7, 2025

A request was made to include the High Flow Magnitude (HFM) layers to their respective public FIM services as sublayers to streamline the user experience of ingesting and understanding FIM. This PR alters the public FIM .mapx files and service descriptions within their .yml files to add their corresponding HFM layers as sublayers within a group layer.

The group layer has default-off visibility to avoid a cluttered map upon opening the map service. The group layers are named to match their corresponding HFM service name. The layers are added to the public FIM .mapx as query layers with the exact same query and symbology as their HFM mapx layers for consistency.

Additions

  1. ANA High Flow Magnitude Est, Annual Exceedance Probability added as sublayer to ANA Inundation Extent. .mapx file updated.
  2. MRF NBM 5Day Max High Flow Magnitude - 5 Days - Est. Annual Exceedance Probability added as sublayer to MRF NBM 5 Day Max Inundation Extent. .mapx file updated.
  3. RFC Max Forecast layers Max Status - Forecast Trend and Record Forecasts layers added as sublayers to RFC Based 5-Day Max Inundation Extent. .mapx file updated.
  4. RFC Based 5-Day Max Streamflow layers 5 Days - Related RFC Forecast Points, 5 Days - Max Flood Status Forecast - Action + Only, and 5 Days - Max Flood Status Forecast - Other Routing layers added as sublayers to RFC Based 5-Day Max Inundation Extent. .mapx file updated.

Removals

Changes

  1. ANA High Flow Magnitude .yml file service description updated.
  2. MRF NBM 5 Day Max Inundation Extent .yml service description updated.
  3. RFC Based 5-Day Max Inundation Extent .yml service description updated.

Testing

Screenshots

Notes

Todos

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows project standards (link if applicable)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 👇)
  • Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Target Environment support

  • Windows
  • Linux
  • Browser

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@GeorgeRought-NOAA GeorgeRought-NOAA added enhancement New feature or request Priority - Medium Task 3 GAMA Task 3 labels Feb 7, 2025
@GeorgeRought-NOAA GeorgeRought-NOAA added this to the V2.2.0 milestone Feb 7, 2025
@GeorgeRought-NOAA GeorgeRought-NOAA self-assigned this Feb 7, 2025
@GeorgeRought-NOAA GeorgeRought-NOAA linked an issue Feb 7, 2025 that may be closed by this pull request
7 tasks
@GeorgeRought-NOAA GeorgeRought-NOAA marked this pull request as ready for review February 7, 2025 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority - Medium Task 3 GAMA Task 3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public FIM Layer to Include High Flow Magnitude as Sublayer
1 participant