Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5pt] PR: Bug fixes for Sierra test #1388

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

Conversation

ZahraGhahremani
Copy link
Contributor

@ZahraGhahremani ZahraGhahremani commented Dec 28, 2024

The vertical lines (recurrence intervals) do not appear in the Sierra test plots. This PR tries to fix this issue as much as possible. Some locations still do not have any vertical lines because they lack USGS rating curve data (missing USGS rating curve data for USGS station x in HUC y). Therefore, this is not a problem.
However, the vertical lines were not plotted previously for some location_ids with more than one feature_id. This FB will always use the first feature_id to plot the vertical lines unless its flow is significantly lower than the USGS maximum flow.

Changes

  • tools/rating_curve_comparison.py

Testing

I tested this branch for HUCs 05010006, 15050302, 07140104.

Deployment Plan (For developer use)

How does the changes affect the product?

  • Code only?
  • If applicable, has a deployment plan be created with the deployment person/team?
  • Require new or adjusted data inputs? Does it have start, end and duration code (in UTC)?
  • If new or updated data sets, has the FIM code been updated and tested with the new/adjusted data (subset is fine, but must be a subset of the new data)?
  • Require new pre-clip set?
  • Has new or updated python packages?

Issuer Checklist (For developer use)

You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

  • Informative and human-readable title, using the format: [_pt] PR: <description>
  • Links are provided if this PR resolves an issue, or depends on another other PR
  • If submitting a PR to the dev branch (the default branch), you have a descriptive Feature Branch name using the format: dev-<description-of-change> (e.g. dev-revise-levee-masking)
  • Changes are limited to a single goal (no scope creep)
  • The feature branch you're submitting as a PR is up to date (merged) with the latest dev branch
  • pre-commit hooks were run locally
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • CHANGELOG updated with template version number, e.g. 4.x.x.x
  • Add yourself as an assignee in the PR as well as the FIM Technical Lead

Merge Checklist (For Technical Lead use only)

  • Update CHANGELOG with latest version number and merge date
  • Update the Citation.cff file to reflect the latest version number in the CHANGELOG
  • If applicable, update README with major alterations

@ZahraGhahremani ZahraGhahremani changed the title [1pt] PR: Bug fixes for Sierra test [5pt] PR: Bug fixes for Sierra test Dec 31, 2024
@ZahraGhahremani ZahraGhahremani linked an issue Dec 31, 2024 that may be closed by this pull request
@ZahraGhahremani ZahraGhahremani marked this pull request as ready for review January 2, 2025 16:37
@ZahraGhahremani ZahraGhahremani added bug Something isn't working enhancement New feature or request Rating Curves labels Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request Rating Curves
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[13pt] Possible bug in Sierra test / rating_curve_comparion
2 participants