[5pt] PR: Bug fixes for Sierra test #1388
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vertical lines (recurrence intervals) do not appear in the Sierra test plots. This PR tries to fix this issue as much as possible. Some locations still do not have any vertical lines because they lack USGS rating curve data (missing USGS rating curve data for USGS station x in HUC y). Therefore, this is not a problem.
However, the vertical lines were not plotted previously for some location_ids with more than one feature_id. This FB will always use the first feature_id to plot the vertical lines unless its flow is significantly lower than the USGS maximum flow.
Changes
tools/rating_curve_comparison.py
Testing
I tested this branch for HUCs
05010006
,15050302
,07140104
.Deployment Plan (For developer use)
How does the changes affect the product?
Issuer Checklist (For developer use)
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.
[_pt] PR: <description>
dev
branch (the default branch), you have a descriptive Feature Branch name using the format:dev-<description-of-change>
(e.g.dev-revise-levee-masking
)dev
branchpre-commit
hooks were run locally4.x.x.x
Merge Checklist (For Technical Lead use only)