-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1pt] WIP: Update stage-based CatFIM to prevent overflooding if stage + elevation is provided in lieu of stage #1397
Draft
EmilyDeardorff
wants to merge
15
commits into
dev
Choose a base branch
from
dev-catfim-v2-2-ky-elev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OAA-OWP/inundation-mapping into dev-catfim-v2-2-site-filtering
…into dev-catfim-v2-2-ky-elev
EmilyDeardorff
changed the title
[1pt] Add workaround to stage-based CatFIM to convert WSE to stage if WSE is mistakenly provided
[1pt] Update stage-based CatFIM to prevent overflooding if stage + elevation is provided in lieu of stage
Jan 7, 2025
RobHanna-NOAA
changed the title
[1pt] Update stage-based CatFIM to prevent overflooding if stage + elevation is provided in lieu of stage
[1pt] WIP: Update stage-based CatFIM to prevent overflooding if stage + elevation is provided in lieu of stage
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some CatFIM sites where the stage values that are provided in the WRDS API actually have the water surface elevation (WSE) rather than the stage value. One site where this is true is site prdk2 in Paradise, KY. At this site, the action stage is listed as 378 ft, which has caused very intense over inundation (as showen in the "before" example below). This code update detects that this issue is occurring and subtracts the elevation from the incorrect "stage" value to produce the actual stage value. In the case of site prdk2, the listed "stage" value is 378 ft, so the gage elevation (363.19 ft) is subtracted to produce the much more reasonable stage value of 14.81 ft. This results in a much more reasonable stage-based CatFIM result, as shown in the "after" example below.
** This PR includes the changes from
dev-catfim-v2-2-site-filtering
, so should be merged after that one! **Addresses vlab ticket #141569.
Changes
inundation-mapping/tools/catfim/generate_categorical_fim.py
: Added an update to detect and fix cases where WSE is provided in lieu of stage.Testing
Site prdk2 before this update:
Site prdk2 after this update:
Deployment Plan (For developer use)
How does the changes affect the product?
Issuer Checklist (For developer use)
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.
[_pt] PR: <description>
dev
branch (the default branch), you have a descriptive Feature Branch name using the format:dev-<description-of-change>
(e.g.dev-revise-levee-masking
)dev
branchpre-commit
hooks were run locally4.x.x.x
Merge Checklist (For Technical Lead use only)