Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1pt] PR: Remove GDAL imports if rasterio is also being used in the same Python interpreter session #1427

Open
wants to merge 24 commits into
base: dev
Choose a base branch
from

Conversation

mluck
Copy link
Contributor

@mluck mluck commented Feb 10, 2025

Removes GDAL imports if rasterio is also being used in the same Python interpreter session.

Resolves #1351, resolves #1402, and resolves #1412.

Changes

  • Dockerfile.owp: renamed from Dockerfile.prod
  • Pipfile and Pipfile.lock: added gemgis, pymc, and rio_vrt; upgraded osmnx
  • data/
    • bathymetry/preprocess_bathymetry.py: Replaced gdal with whitebox
    • ble/ble_benchmark/
      • create_ble_benchmark.py: Replaced GDAL with gemgis and whitebox
      • preprocess_benchmark.py: Added with context for rasterio.open()
  • src/utils/shared_functions.py: Remove unused function and rasterio import
  • tools/inundate_nation.py: Replaced gdal with rio_vrt and whitebox

Testing

Ran preprocess_bathymetry.py on two eHydro TIFs and create_ble_benchmark.py on 12030105. Ran inundate_nation.py on several HUCs (03100204, 12040101, 12090301).

Deployment Plan (For developer use)

How does the changes affect the product?

  • Code only?
  • If applicable, has a deployment plan be created with the deployment person/team?
  • Require new or adjusted data inputs? Does it have start, end and duration code (in UTC)?
  • If new or updated data sets, has the FIM code been updated and tested with the new/adjusted data (subset is fine, but must be a subset of the new data)?
  • Require new pre-clip set?
  • Has new or updated python packages?

Issuer Checklist (For developer use)

You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

  • Informative and human-readable title, using the format: [_pt] PR: <description>
  • Links are provided if this PR resolves an issue, or depends on another other PR
  • If submitting a PR to the dev branch (the default branch), you have a descriptive Feature Branch name using the format: dev-<description-of-change> (e.g. dev-revise-levee-masking)
  • Changes are limited to a single goal (no scope creep)
  • The feature branch you're submitting as a PR is up to date (merged) with the latest dev branch
  • pre-commit hooks were run locally
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • CHANGELOG updated with template version number, e.g. 4.x.x.x
  • Add yourself as an assignee in the PR as well as the FIM Technical Lead

Merge Checklist (For Technical Lead use only)

  • Update CHANGELOG with latest version number and merge date
  • Update the Citation.cff file to reflect the latest version number in the CHANGELOG
  • If applicable, update README with major alterations

@mluck mluck added bug Something isn't working refactoring Refacting code to obtain the same result dependencies Pull requests that update a dependency file labels Feb 10, 2025
@mluck mluck self-assigned this Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file refactoring Refacting code to obtain the same result
Projects
None yet
1 participant