-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1pt] PR: Remove GDAL imports if rasterio is also being used in the same Python interpreter session #1427
Open
mluck
wants to merge
24
commits into
dev
Choose a base branch
from
dev-cleanup-gdal
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion-mapping into dev-cleanup-gdal
…tion-mapping into dev-cleanup-gdal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
dependencies
Pull requests that update a dependency file
refactoring
Refacting code to obtain the same result
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes GDAL imports if
rasterio
is also being used in the same Python interpreter session.Resolves #1351, resolves #1402, and resolves #1412.
Changes
Dockerfile.owp
: renamed fromDockerfile.prod
Pipfile
andPipfile.lock
: addedgemgis
,pymc
, andrio_vrt
; upgradedosmnx
data/
bathymetry/preprocess_bathymetry.py
: Replacedgdal
withwhitebox
ble/ble_benchmark/
create_ble_benchmark.py
: Replaced GDAL withgemgis
andwhitebox
preprocess_benchmark.py
: Addedwith
context forrasterio.open()
src/utils/shared_functions.py
: Remove unused function andrasterio
importtools/inundate_nation.py
: Replacedgdal
withrio_vrt
andwhitebox
Testing
Ran
preprocess_bathymetry.py
on two eHydro TIFs andcreate_ble_benchmark.py
on 12030105. Raninundate_nation.py
on several HUCs (03100204, 12040101, 12090301).Deployment Plan (For developer use)
How does the changes affect the product?
Issuer Checklist (For developer use)
You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.
[_pt] PR: <description>
dev
branch (the default branch), you have a descriptive Feature Branch name using the format:dev-<description-of-change>
(e.g.dev-revise-levee-masking
)dev
branchpre-commit
hooks were run locally4.x.x.x
Merge Checklist (For Technical Lead use only)