Skip to content

Conversation

ZahraGhahremani
Copy link
Contributor

@ZahraGhahremani ZahraGhahremani commented Jul 19, 2025

This PR fixes issue with box plot generation and introduces a new function to compare two FIM outputs.

Changes

tools/rating_curve_comparison.py : changes as described above.

Testing

Tested for comparing FIM v5 vs. FIM v6 outputs.

Deployment Plan (For developer use)

How does the changes affect the product?

  • Code only?
  • If applicable, has a deployment plan be created with the deployment person/team?
  • Require new or adjusted data inputs? Does it have start, end and duration code (in UTC)?
  • If new or updated data sets, has the FIM code been updated and tested with the new/adjusted data (subset is fine, but must be a subset of the new data)?
  • Require new pre-clip set?
  • Has new or updated python packages?

Issuer Checklist (For developer use)

You may update this checklist before and/or after creating the PR. If you're unsure about any of them, please ask, we're here to help! These items are what we are going to look for before merging your code.

  • Informative and human-readable title, using the format: [_pt] PR: <description>
  • Links are provided if this PR resolves an issue, or depends on another other PR
  • If submitting a PR to the dev branch (the default branch), you have a descriptive Feature Branch name using the format: dev-<description-of-change> (e.g. dev-revise-levee-masking)
  • Changes are limited to a single goal (no scope creep)
  • The feature branch you're submitting as a PR is up to date (merged) with the latest dev branch
  • pre-commit hooks were run locally
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • CHANGELOG updated with template version number, e.g. 4.x.x.x
  • Add yourself as an assignee in the PR as well as the FIM Technical Lead

Merge Checklist (For Technical Lead use only)

  • Update CHANGELOG with latest version number and merge date
  • Update the Citation.cff file to reflect the latest version number in the CHANGELOG
  • If applicable, update README with major alterations

@ZahraGhahremani ZahraGhahremani changed the title [WIP] Fixed bugs and added comparison plots [3pt] WIP: Fixed Sierra test bugs and added comparison plots Jul 19, 2025
@ZahraGhahremani ZahraGhahremani self-assigned this Jul 19, 2025
@ZahraGhahremani ZahraGhahremani added bug Something isn't working enhancement New feature or request labels Jul 19, 2025
@ZahraGhahremani ZahraGhahremani linked an issue Jul 19, 2025 that may be closed by this pull request
@ZahraGhahremani ZahraGhahremani changed the title [3pt] WIP: Fixed Sierra test bugs and added comparison plots [3pt] PR: Fixed Sierra test bugs and added comparison plots Aug 20, 2025
@ZahraGhahremani ZahraGhahremani marked this pull request as ready for review August 20, 2025 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[5pt] Sierra test fails to create static GPKG
2 participants